From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@intel.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <fengyuleidian0615@gmail.com>
Subject: Re: [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host
Date: Fri, 6 Mar 2015 07:13:47 +0100 [thread overview]
Message-ID: <20150306061347.GA3311@secunet.com> (raw)
In-Reply-To: <1422349230-17394-1-git-send-email-fan.du@intel.com>
On Tue, Jan 27, 2015 at 05:00:29PM +0800, Fan Du wrote:
> structure like xfrm_usersa_info or xfrm_userpolicy_info
> has different sizeof when compiled as 32bits and 64bits
> due to not appending pack attribute in their definition.
> This will result in broken SA and SP information when user
> trying to configure them through netlink interface.
>
> Inform user land about this situation instead of keeping
> silent, the upper test scripts would behave accordingly.
>
> Quotes from: http://marc.info/?l=linux-netdev&m=142226348715503&w=2
> >
> > Before a clean solution show up, I think it's better to warn user in some way
> > like http://patchwork.ozlabs.org/patch/323842/ did. Otherwise, many people
> > who stuck there will always spend time and try to fix this issue in whatever way.
>
> Yes, this is the first thing we should do. I'm willing to accept a patch
>
> Signed-off-by: Fan Du <fan.du@intel.com>
Now applied to ipsec-next, thanks a lot Fan!
prev parent reply other threads:[~2015-03-06 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150127.001226.711259930266409202.davem () davemloft ! net>
2015-01-27 9:00 ` [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host Fan Du
2015-01-27 9:46 ` David Laight
2015-01-27 11:04 ` Florian Westphal
2015-01-27 11:54 ` David Laight
2015-01-27 19:24 ` David Miller
2015-01-28 9:53 ` David Laight
2015-01-28 4:34 ` Fan Du
2015-01-29 10:29 ` [PATCHv3, " Nicolas Dichtel
2015-01-29 13:56 ` David Laight
2015-01-29 14:14 ` Nicolas Dichtel
2015-01-30 2:11 ` Fan Du
2015-02-02 8:44 ` Steffen Klassert
2015-02-02 9:02 ` Nicolas Dichtel
2015-02-02 19:45 ` David Miller
2015-02-03 12:24 ` Steffen Klassert
2015-02-03 14:02 ` Nicolas Dichtel
2015-03-06 6:13 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306061347.GA3311@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@intel.com \
--cc=fengyuleidian0615@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).