From: Stephen Hemminger <stephen@networkplumber.org>
To: Jeff Kirsher <tarbal@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vlan: allow changing VLAN id and protocol
Date: Sun, 8 Mar 2015 14:44:32 -0700 [thread overview]
Message-ID: <20150308144432.02f9c311@urahara> (raw)
In-Reply-To: <54FC9426.7040708@gmail.com>
On Sun, 08 Mar 2015 11:25:42 -0700
Jeff Kirsher <tarbal@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 03/08/2015 11:06 AM, Stephen Hemminger wrote:
> >
> > The VLAN netlink interface allows changing the ID and protocol of an existing
> > VLAN, but it was being ignored. Move the initialization of the proto and
> > id into the change function to fix that.
> >
> > Example of the problem:
> > # modprobe dummy
> > # ip li set dev dummy0 up
> > # ip li add link dummy0 name dummy0.10 type vlan id 100
> > # ip li set dummy0.10 type vlan id 111
> > # ip -d li show dev dummy0.10
> > 19: dummy0.10@dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT
> > link/ether be:d3:7c:7f:86:18 brd ff:ff:ff:ff:ff:ff
> > vlan id 100 <REORDER_HDR>
> > ^^^ should be 111
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Self-NAK
This needs more state work to handle the case of GARP and all the
filtering stuff. There be small dragons here.
prev parent reply other threads:[~2015-03-08 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 18:06 [PATCH net-next] vlan: allow changing VLAN id and protocol Stephen Hemminger
2015-03-08 18:25 ` Jeff Kirsher
2015-03-08 21:44 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308144432.02f9c311@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tarbal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).