From: David Miller <davem@redhat.com>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: rhashtable: Move hash_rnd into bucket_table
Date: Mon, 09 Mar 2015 15:51:37 -0400 (EDT) [thread overview]
Message-ID: <20150309.155137.26393830527159591.davem@redhat.com> (raw)
In-Reply-To: <20150309095833.GA4028@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 9 Mar 2015 20:58:33 +1100
> Currently hash_rnd is a parameter that users can set. However,
> no existing users set this parameter. It is also something that
> people are unlikely to want to set directly since it's just a
> random number.
>
> In preparation for allowing the reseeding/rehashing of rhashtable,
> this patch moves hash_rnd into bucket_table so that it's now an
> internal state rather than a parameter.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Thomas is right, you're going to have to move the hash_rnd initialization
to where we allocate the bucket tables, otherwise the first shrink/expand
will set it to zero.
next prev parent reply other threads:[~2015-03-09 19:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 10:21 rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-01-31 10:23 ` [RFC] rhashtable: rhashtable_rehash Herbert Xu
2015-02-02 11:16 ` Thomas Graf
2015-03-09 10:13 ` Herbert Xu
2015-01-31 11:17 ` rhashtable: Move hash_rnd into bucket_table Thomas Graf
2015-02-03 3:19 ` David Miller
2015-02-03 3:26 ` David Miller
2015-02-03 20:17 ` Herbert Xu
2015-02-03 20:32 ` [PATCH 0/4] rhashtable: Add iterators and use them Herbert Xu
2015-02-03 20:33 ` [PATCH 1/4] rhashtable: Fix potential crash on destroy in rhashtable_shrink Herbert Xu
2015-02-03 20:33 ` [PATCH 2/4] rhashtable: Introduce rhashtable_walk_* Herbert Xu
2015-02-03 20:33 ` [PATCH 3/4] netlink: Use rhashtable walk iterator Herbert Xu
2015-02-05 0:25 ` Thomas Graf
2015-02-03 20:33 ` [PATCH 4/4] netfilter: " Herbert Xu
2015-02-05 4:35 ` [PATCH 0/4] rhashtable: Add iterators and use them David Miller
2015-03-09 9:58 ` rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-03-09 16:26 ` Daniel Borkmann
2015-03-09 22:21 ` Herbert Xu
2015-03-09 19:51 ` David Miller [this message]
2015-03-09 19:55 ` David Miller
2015-03-09 22:26 ` [PATCH 0/2] rhashtable: Arbitrary rehashing Herbert Xu
2015-03-09 22:27 ` [PATCH 1/2] rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-03-10 17:20 ` Thomas Graf
2015-03-10 21:48 ` Herbert Xu
2015-03-09 22:27 ` [PATCH 2/2] rhashtable: Add arbitrary rehash function Herbert Xu
2015-03-10 18:17 ` Thomas Graf
2015-03-10 22:01 ` Herbert Xu
2015-03-10 22:43 ` [PATCH v2] " Herbert Xu
2015-03-11 20:37 ` David Miller
2015-03-11 21:07 ` Herbert Xu
2015-03-09 22:32 ` [PATCH 0/2] rhashtable: Arbitrary rehashing Josh Triplett
2015-03-10 18:20 ` Thomas Graf
2015-03-12 16:46 ` Thomas Graf
2015-03-13 1:54 ` Herbert Xu
2015-03-13 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309.155137.26393830527159591.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).