[PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[shh.xie]

From: Shaohui Xie <Shaohui.Xie@freescale.com>

FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
can build on non-PPC platforms.

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
 drivers/net/ethernet/freescale/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index ba84c4a..25e3425 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -58,14 +58,12 @@ source "drivers/net/ethernet/freescale/fs_enet/Kconfig"
 
 config FSL_PQ_MDIO
 	tristate "Freescale PQ MDIO"
-	depends on FSL_SOC
 	select PHYLIB
 	---help---
 	  This driver supports the MDIO bus used by the gianfar and UCC drivers.
 
 config FSL_XGMAC_MDIO
 	tristate "Freescale XGMAC MDIO"
-	depends on FSL_SOC
 	select PHYLIB
 	select OF_MDIO
 	---help---
-- 
1.8.4.1

Re: [linuxppc-release] [PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[Emil Medve]

Hello Shao-Hui,


On 03/10/2015 05:31 AM, shh.xie@gmail.com wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> can build on non-PPC platforms.

FSL_SOC is already defined for some ARM-based SoC? Why don't you use/fix
that. We have plenty of devices integrated on both SoC families...

Or are you targeting other non-PPC/ARM SoC(s)?


Cheers,


> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ba84c4a..25e3425 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -58,14 +58,12 @@ source "drivers/net/ethernet/freescale/fs_enet/Kconfig"
>  
>  config FSL_PQ_MDIO
>  	tristate "Freescale PQ MDIO"
> -	depends on FSL_SOC
>  	select PHYLIB
>  	---help---
>  	  This driver supports the MDIO bus used by the gianfar and UCC drivers.
>  
>  config FSL_XGMAC_MDIO
>  	tristate "Freescale XGMAC MDIO"
> -	depends on FSL_SOC
>  	select PHYLIB
>  	select OF_MDIO
>  	---help---
> 

RE: [linuxppc-release] [PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[Shaohui Xie]

Hello Emil,

> On 03/10/2015 05:31 AM, shh.xie@gmail.com wrote:
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> > FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> > can build on non-PPC platforms.
> 
> FSL_SOC is already defined for some ARM-based SoC? Why don't you use/fix
> that.
[S.H] I grep on top of the net-next tree, only found the FSL_SOC defined in arch/powerpc/Kconfig.

 We have plenty of devices integrated on both SoC families...
> 
> Or are you targeting other non-PPC/ARM SoC(s)?
[S.H] the point is to remove the unnecessary dependency to make the driver can build ARCH independently, no matter what the SoC is.

Thanks!
Shaohui

> 
> 
> Cheers,
> 
> 
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > ---
> >  drivers/net/ethernet/freescale/Kconfig | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/Kconfig
> > b/drivers/net/ethernet/freescale/Kconfig
> > index ba84c4a..25e3425 100644
> > --- a/drivers/net/ethernet/freescale/Kconfig
> > +++ b/drivers/net/ethernet/freescale/Kconfig
> > @@ -58,14 +58,12 @@ source
> "drivers/net/ethernet/freescale/fs_enet/Kconfig"
> >
> >  config FSL_PQ_MDIO
> >  	tristate "Freescale PQ MDIO"
> > -	depends on FSL_SOC
> >  	select PHYLIB
> >  	---help---
> >  	  This driver supports the MDIO bus used by the gianfar and UCC
> drivers.
> >
> >  config FSL_XGMAC_MDIO
> >  	tristate "Freescale XGMAC MDIO"
> > -	depends on FSL_SOC
> >  	select PHYLIB
> >  	select OF_MDIO
> >  	---help---
> >

Re: [PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[David Miller]

From: <shh.xie@gmail.com>
Date: Tue, 10 Mar 2015 18:31:12 +0800

> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> can build on non-PPC platforms.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>

Applied to net-next, thanks.

Re: [PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

On Tue, 2015-03-10 at 18:31 +0800, shh.xie@gmail.com wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> can build on non-PPC platforms.

If this hardware can actually be used on other architectures, fine.

If not, the dependency should be FSL_SOC || COMPILE_TEST so that the
option is only available on other architectures when developers want to
check that these drivers build.

Ben.

> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ba84c4a..25e3425 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -58,14 +58,12 @@ source "drivers/net/ethernet/freescale/fs_enet/Kconfig"
>  
>  config FSL_PQ_MDIO
>  	tristate "Freescale PQ MDIO"
> -	depends on FSL_SOC
>  	select PHYLIB
>  	---help---
>  	  This driver supports the MDIO bus used by the gianfar and UCC drivers.
>  
>  config FSL_XGMAC_MDIO
>  	tristate "Freescale XGMAC MDIO"
> -	depends on FSL_SOC
>  	select PHYLIB
>  	select OF_MDIO
>  	---help---

-- 
Ben Hutchings
Q.  Which is the greater problem in the world today, ignorance or apathy?
A.  I don't know and I couldn't care less.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

RE: [PATCH] net/fsl: remove dependency FSL_SOC from MDIO

[Shaohui Xie]

> -----Original Message-----
> From: Ben Hutchings [mailto:ben@decadent.org.uk]
> Sent: Sunday, March 15, 2015 4:14 AM
> To: shh.xie@gmail.com
> Cc: netdev@vger.kernel.org; davem@davemloft.net; Xie Shaohui-B21989
> Subject: Re: [PATCH] net/fsl: remove dependency FSL_SOC from MDIO
> 
> On Tue, 2015-03-10 at 18:31 +0800, shh.xie@gmail.com wrote:
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> > FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> > can build on non-PPC platforms.
> 
> If this hardware can actually be used on other architectures, fine.
[S.H] Yes. The hardware does exist in other Soc, e.g. FSL_PQ_MDIO in LS1021A,
FSL_XGMAC_MDIO in LS2085A, which are both ARM.

> 
> If not, the dependency should be FSL_SOC || COMPILE_TEST so that the
> option is only available on other architectures when developers want to
> check that these drivers build.
[S.H] If developers want to check these drivers build, the MDIO config should 
Be selected in a given kernel config file.

Thanks!
Shaohui