Re: [PATCH] mm: kill kmemcheck

Steven Rostedt
2015-03-11T14:52:10Z

On Wed, 11 Mar 2015 10:43:29 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:

> On 03/11/2015 10:26 AM, Steven Rostedt wrote:
> >> There's no real hurry to kill kmemcheck right now, but we do want to stop
> >> > supporting that in favour of KASan.
> > Understood, but the kernel is suppose to support older compilers.
> > Perhaps we can keep kmemcheck for now and say it's obsoleted if you
> > have a newer compiler. Because it will be a while before I upgrade my
> > compilers. I don't upgrade unless I have a good reason to do so. Not
> > sure KASan fulfills that requirement.
>
> It's not that there's a performance overhead with kmemcheck, it's the
> maintenance effort that we want to get rid of.

I totally understand this.

>
> The kernel should keep supporting old kernels, and after this kmemcheck
> removal your kernel will still keep working - this is more of a removal
> of a mostly unused feature that had hooks everywhere in the kernel.
>
> Did you actually find anything recently with kmemcheck?

I have to look. I think I did find something last year. I run it every
other month or so, so it's not something I do every day.

> How do you deal
> with the 1 CPU limit and the massive performance hit?

I just deal with it :-)

I have test boxes that I kick off and just let run. It's not that bad
if you are not using the box for actual work.

>
> Could you try KASan for your use case and see if it potentially uncovers
> anything new?

The problem is, I don't have a setup to build with the latest compiler.

I could build with my host compiler (that happens to be 4.9.2), but it
would take a while to build, and is not part of my work flow.

4.9.2 is very new, I think it's a bit premature to declare that the
only way to test memory allocations is with the latest and greatest
kernel.

But if kmemcheck really doesn't work anymore, than perhaps we should
get rid of it.

-- Steve