From: Andrew Lunn <andrew@lunn.ch>
To: Mathieu Olivari <mathieu@codeaurora.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonas Gorski <jogo@openwrt.org>
Subject: Re: RFC: dsa: add support for multiple CPU ports
Date: Wed, 11 Mar 2015 14:30:57 +0100 [thread overview]
Message-ID: <20150311133057.GA9601@lunn.ch> (raw)
In-Reply-To: <20150311011802.GA10875@codeaurora.org>
> We already have existing interface for eth0/eth1. Maybe we should
> consider allowing them to be bridge. User configuration would look like
> this:
>
> brctl addbr br-lan
> brctl addif br-lan eth1
> brctl addif br-lan lan1
> brctl addif br-lan lan2
> brctl addif br-lan lan3
> brctl addif br-lan lan4
Think about this from the perspective of somebody how does not know
there is a switch. When i look at this, to me it means packets from
lan1, lan2, lan3, lan4 and eth1 are bridged together. So we are going
to get packets sent out eth1 without a tag on it, and the switch is
very likely to drop it, since the port is in a mode which expects a
tag. You are not using the brctl command with its normal meaning,
which is bad.
Configuring this at the bridge layer is also wrong. What conduit a DSA
slave interfaces uses is a DSA layer issue.
Before we can come up with a nice solution, i think we first need to
understand what the switches are capable off. If trunking does work,
it is a relatively nice system for the user to configure, in that
there is nothing for the user to configure! Assuming the switch can do
reasonable load balancing, we also get near optimal usage of the two
conduits.
I don't know when i will have time to play with this, and if somebody
comes along with a better idea, i'm very open to adopting that idea
over mine.
Andrew
next prev parent reply other threads:[~2015-03-11 13:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 19:01 RFC: dsa: add support for multiple CPU ports Mathieu Olivari
2015-03-10 19:21 ` Andrew Lunn
2015-03-10 22:13 ` Mathieu Olivari
2015-03-10 22:50 ` Andrew Lunn
2015-03-10 19:31 ` Andrew Lunn
2015-03-10 20:42 ` Mathieu Olivari
2015-03-10 21:13 ` Andrew Lunn
2015-03-10 22:53 ` Mathieu Olivari
2015-03-11 1:47 ` David Miller
2015-03-11 13:07 ` Jiri Pirko
2015-03-11 0:01 ` Florian Fainelli
2015-03-11 1:18 ` Mathieu Olivari
2015-03-11 13:30 ` Andrew Lunn [this message]
2015-03-11 23:37 ` Mathieu Olivari
2015-03-12 0:19 ` Andrew Lunn
2015-03-13 1:57 ` Mathieu Olivari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311133057.GA9601@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux@roeck-us.net \
--cc=mathieu@codeaurora.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).