From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch net-next] switchdev: select INET in Kconfig
Date: Wed, 11 Mar 2015 17:20:16 +0100
Message-ID: <20150311162016.GF2057@nanopsycho.orion>
References: <CAADnVQ+vnKJ=KHvMdy2f_82r=d7dS9HuNXKJt6=vMgjY0OE+Ag@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Feldman <sfeldma@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wg0-f42.google.com ([74.125.82.42]:45010 "EHLO
	mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751330AbbCKQUV (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 11 Mar 2015 12:20:21 -0400
Received: by wghl18 with SMTP id l18so10377615wgh.11
        for <netdev@vger.kernel.org>; Wed, 11 Mar 2015 09:20:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAADnVQ+vnKJ=KHvMdy2f_82r=d7dS9HuNXKJt6=vMgjY0OE+Ag@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Mar 11, 2015 at 04:36:16PM CET, alexei.starovoitov@gmail.com wrote:
>On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> This would fix randconfig compile error:
>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>
>> Also it fixes following warning:
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>
>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>> ---
>>  net/switchdev/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>> index 86a47e1..3487940 100644
>> --- a/net/switchdev/Kconfig
>> +++ b/net/switchdev/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>  config NET_SWITCHDEV
>>         bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>> -       depends on INET
>> +       select INET
>
>I believe Dave mentioned few times that 'select' is highly
>discouraged, since it doesn't work recursively.
>In this case only crazy config KVMTOOL_TEST_ENABLE
>is doing 'select INET' everything else in a tree is using
>'depends on INET'.
>Doing 'select NET_SWITCHDEV' was wrong in the first place.

Ok, so you suggest just to change this to "depends on NET_SWITCHDEV" in
DSA and we are good?

Thanks.