* [PATCH 0/15] don't export static symbol
@ 2015-03-11 16:56 Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: alsa-devel, linux-nfs, linux-scsi, linux-rdma, kernel-janitors,
linux-wireless, linux-kernel, linux-wpan, target-devel,
linux-crypto, netdev, linux-media, linuxppc-dev, linux-edac
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/15] net/mlx5_core: don't export static symbol
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
2015-03-12 4:04 ` David Miller
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Eli Cohen; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -697,7 +697,6 @@ err_dbg:
debugfs_remove(priv->dbg_root);
return err;
}
-EXPORT_SYMBOL(mlx5_dev_init);
static void mlx5_dev_cleanup(struct mlx5_core_dev *dev)
{
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 8/15] libertas_tf: if_usb.c: don't export static symbol
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
2015-03-13 14:18 ` [8/15] " Kalle Valo
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Kalle Valo; +Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/wireless/libertas_tf/if_usb.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/drivers/net/wireless/libertas_tf/if_usb.c b/drivers/net/wireless/libertas_tf/if_usb.c
--- a/drivers/net/wireless/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/libertas_tf/if_usb.c
@@ -365,7 +365,6 @@ static int if_usb_reset_device(struct if
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_reset_device);
/**
* usb_tx_block - transfer data to the device
@@ -907,7 +906,6 @@ restart:
lbtf_deb_leave_args(LBTF_DEB_USB, "ret %d", ret);
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_prog_firmware);
#define if_usb_suspend NULL
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
2015-03-11 18:17 ` Alexander Aring
2015-03-14 16:13 ` Marcel Holtmann
2 siblings, 2 replies; 8+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Alexander Aring
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
net/ieee802154/nl-mac.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
--- a/net/ieee802154/nl-mac.c
+++ b/net/ieee802154/nl-mac.c
@@ -76,7 +76,6 @@ nla_put_failure:
nlmsg_free(msg);
return -ENOBUFS;
}
-EXPORT_SYMBOL(ieee802154_nl_start_confirm);
static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
u32 seq, int flags, struct net_device *dev)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
@ 2015-03-11 18:17 ` Alexander Aring
2015-03-14 16:13 ` Marcel Holtmann
1 sibling, 0 replies; 8+ messages in thread
From: Alexander Aring @ 2015-03-11 18:17 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel, marcel
On Wed, Mar 11, 2015 at 05:56:35PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel can you please queue this into bluetooth-next, or even bluetooth?
Thanks.
- Alex
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/15] net/mlx5_core: don't export static symbol
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
@ 2015-03-12 4:04 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-12 4:04 UTC (permalink / raw)
To: Julia.Lawall
Cc: eli, kernel-janitors, netdev, linux-rdma, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 11 Mar 2015 17:56:25 +0100
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thank you Julia.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [8/15] libertas_tf: if_usb.c: don't export static symbol
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
@ 2015-03-13 14:18 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-13 14:18 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2015-03-11 18:17 ` Alexander Aring
@ 2015-03-14 16:13 ` Marcel Holtmann
1 sibling, 0 replies; 8+ messages in thread
From: Marcel Holtmann @ 2015-03-14 16:13 UTC (permalink / raw)
To: Julia Lawall
Cc: Alexander Aring, kernel-janitors, David S. Miller, linux-wpan,
netdev, Linux Kernel Mailing List, daniel
Hi Julia,
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> net/ieee802154/nl-mac.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-14 16:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
2015-03-12 4:04 ` David Miller
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
2015-03-13 14:18 ` [8/15] " Kalle Valo
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2015-03-11 18:17 ` Alexander Aring
2015-03-14 16:13 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).