From: Nicholas Mc Guire <der.herr@hofr.at>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Valdis.Kletnieks@vt.edu, Bj??rn Mork <bjorn@mork.no>,
Jeff Haran <Jeff.Haran@citrix.com>,
Pat Erley <pat-lkml@erley.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function
Date: Wed, 11 Mar 2015 20:15:26 +0100 [thread overview]
Message-ID: <20150311191526.GA24455@opentech.at> (raw)
In-Reply-To: <1426101010.1904.9.camel@sipsolutions.net>
On Wed, 11 Mar 2015, Johannes Berg wrote:
> On Wed, 2015-03-11 at 15:01 -0400, Nicholas Mc Guire wrote:
> > Putting code into the parameter list of wait_event_timeout() might be
> > legal C-code but not really readable - the "inline" code is simply
> > moved into a function and that passed to wait_event_timeout() as the
> > condition.
>
> Arguably, that's even more unreadable since if you don't know this macro
> well you might assume the function is called only once, which is clearly
> not true...
>
> Don't get me wrong, I'm not opposed to this change, but if you ask me
> it's not completely clear that this makes it more readable.
>
I'm not into this long enough to say what is better and if the consensus
is that this patch is no more readable than the original code
and no more maintainable either, then it is not worth the effort.
so thanks for your comments!
thx!
hofrat
next prev parent reply other threads:[~2015-03-11 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 19:01 [PATCH RFC v2] ath10k: move code from parameter list into a function Nicholas Mc Guire
2015-03-11 19:10 ` Johannes Berg
2015-03-11 19:15 ` Nicholas Mc Guire [this message]
2015-03-11 19:22 ` Johannes Berg
2015-03-11 20:29 ` Sergei Shtylyov
2015-03-12 7:32 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311191526.GA24455@opentech.at \
--to=der.herr@hofr.at \
--cc=Jeff.Haran@citrix.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=ath10k@lists.infradead.org \
--cc=bjorn@mork.no \
--cc=hofrat@osadl.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pat-lkml@erley.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).