From: Martin Lau <kafai@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>, <netdev@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [Question] net/mlx4_en: Memory consumption issue with mlx4_en driver
Date: Thu, 12 Mar 2015 09:56:47 -0700 [thread overview]
Message-ID: <20150312165647.GD1032293@devbig242.prn2.facebook.com> (raw)
In-Reply-To: <1426105262.11398.66.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Mar 11, 2015 at 01:21:02PM -0700, Eric Dumazet wrote:
> You know, even the order-3 allocations done for regular skb allocations
> will hurt you : a single copybreaked skb stored a long time in a tcp
> receive queue will hold 32KB of memory.
>
> Even 4KB can lead to disasters.
Thanks for the pointer. I look a little deeper at the allocation in skbuff.c.
I can see your point.
> You could lower tcp_rmem so that collapsing happens sooner.
It is what we did. However, a buggy process accommodated enough stalled
sockets (stop reading from it but not closing it) will re-surface the problem.
Thanks,
--Martin
next prev parent reply other threads:[~2015-03-12 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 18:51 [Question] net/mlx4_en: Memory consumption issue with mlx4_en driver Martin Lau
2015-03-11 20:21 ` Eric Dumazet
2015-03-11 20:23 ` Eric Dumazet
2015-03-12 16:56 ` Martin Lau [this message]
2015-03-12 17:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312165647.GD1032293@devbig242.prn2.facebook.com \
--to=kafai@fb.com \
--cc=amirv@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).