netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: rockford@yandex.ru, b38611@freescale.com, netdev@vger.kernel.org
Subject: Re: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is broken. In 4.0.0-rc3
Date: Fri, 13 Mar 2015 12:41:38 -0400 (EDT)	[thread overview]
Message-ID: <20150313.124138.958968404157280157.davem@davemloft.net> (raw)
In-Reply-To: <1426254527.4173.98.camel@decadent.org.uk>

From: Ben Hutchings <ben@decadent.org.uk>
Date: Fri, 13 Mar 2015 13:48:47 +0000

> On Mon, 2015-03-09 at 22:50 +0300, Панов Андрей wrote:
>> Hello!
>> 
>> Commit 2b995f63987013bacde99168218f9c7b252bdcf1 in 4.0.0-rc3 introduces a nasty bug in transmit, corrupting packets.
>> 
>> To reproduce:
>> 
>> $ dd if=/dev/zero of=zeros bs=1M count=20
>> $ md5sum -b zeros
>> 8f4e33f3dc3e414ff94e5fb6905cba8c *zeros
>> 
>> This checksum is correct.
>> 
>> Copy file "zeros" to another host with NFS, and it gets corrupted, checksum is changed.
>> File should be big, small amounts of transmit isn't affected.
>> 
>> I use an i.MX6 Quad board.
>> 
>> If this commit is reverted, all works fine.
> 
> And the bug described in the commit message doesn't seem to exist in the
> previous version.  The change just doesn't make sense to me.
> 
> I seem to remember DMA debug checks sometimes causing false positives
> for network I/O, too.

I'd be happy to apply a revert.

      reply	other threads:[~2015-03-13 16:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 19:50 Bug in drivers/net/ethernet/freescale/fec_main.c, TX is broken. In 4.0.0-rc3 Панов Андрей
2015-03-10 20:12 ` Панов Андрей
2015-03-16  9:21   ` fugang.duan
2015-03-16 13:37     ` Панов Андрей
2015-03-16 14:01       ` fugang.duan
2015-03-16 19:09         ` Панов Андрей
     [not found]         ` <994171426532944@web7m.yandex.ru>
2015-03-17  1:49           ` fugang.duan
2015-03-21 20:53           ` Russell King - ARM Linux
2015-03-21 22:35             ` Fabio Estevam
2015-03-22 20:08               ` Панов Андрей
2015-03-23  2:42               ` fugang.duan
2015-03-23  8:22                 ` Панов Андрей
2015-03-13 13:48 ` Ben Hutchings
2015-03-13 16:41   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313.124138.958968404157280157.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=b38611@freescale.com \
    --cc=ben@decadent.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=rockford@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).