From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, paul.gortmaker@windriver.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next 0/7] tipc: some optimizations and impovements
Date: Fri, 13 Mar 2015 12:52:27 -0400 (EDT) [thread overview]
Message-ID: <20150313.125227.1523044445570081158.davem@davemloft.net> (raw)
In-Reply-To: <1426256860-31208-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Fri, 13 Mar 2015 10:27:33 -0400
> The commits in this series contain some relatively simple changes
> that lead to better throughput across TIPC connections. We also make
> changes to the implementation of link transmission queueing and priority
> handling, in order to make the code more comprehensible and maintainable.
I think you should do the SKB linearization changes properly.
Simply do pskb_may_pull() before you inspect any header, and you can
do this everwhere, even your bundling extraction code path.
I also don't think you even need to clone the SKB there either.
Thanks.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
next prev parent reply other threads:[~2015-03-13 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 14:27 [PATCH net-next 0/7] tipc: some optimizations and impovements Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 1/7] tipc: add framework for node capabilities exchange Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 2/7] tipc: move message validation function to msg.c Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 3/7] tipc: eliminate unnecessary linearization of incoming buffers Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 4/7] tipc: extract bundled buffers by cloning instead of copying Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 5/7] tipc: eliminate unnecessary call to broadcast ack function Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 6/7] tipc: split link outqueue Jon Maloy
2015-03-13 14:27 ` [PATCH net-next 7/7] tipc: clean up handling of message priorities Jon Maloy
2015-03-13 16:52 ` David Miller [this message]
2015-03-13 17:09 ` [PATCH net-next 0/7] tipc: some optimizations and impovements Jon Maloy
2015-03-13 19:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313.125227.1523044445570081158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).