From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, paul.gortmaker@windriver.com,
erik.hugne@ericsson.com, ying.xue@windriver.com,
maloy@donjonn.com, tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next v2 0/7] tipc: some optimizations and impovements
Date: Sat, 14 Mar 2015 14:39:02 -0400 (EDT) [thread overview]
Message-ID: <20150314.143902.386608049896474304.davem@davemloft.net> (raw)
In-Reply-To: <1426277291-2427-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Fri, 13 Mar 2015 16:08:04 -0400
> The commits in this series contain some relatively simple changes that
> lead to better throughput across TIPC connections. We also make changes
> to the implementation of link transmission queueing and priority
> handling, in order to make the code more comprehensible and maintainable.
>
> v2: Commit #2: Redesigned tipc_msg_validate() to use pskb_may_pull(),
> as per feedback from David Miller.
> Commit #3: Some cosmetic changes to tipc_msg_extract(). I tried to
> replace the unconditional skb_linearize() with calls to
> pskb_may_pull() at selected locations, but I gave up.
> First, skb_trim() requires a fully linearized buffer.
> Second, it doesn't make much sense; the whole buffer
> will end up linearized, one way or another.
Series applied, thanks Jon.
prev parent reply other threads:[~2015-03-14 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 20:08 [PATCH net-next v2 0/7] tipc: some optimizations and impovements Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 1/7] tipc: add framework for node capabilities exchange Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 2/7] tipc: move message validation function to msg.c Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 3/7] tipc: eliminate unnecessary linearization of incoming buffers Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 4/7] tipc: extract bundled buffers by cloning instead of copying Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 5/7] tipc: eliminate unnecessary call to broadcast ack function Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 6/7] tipc: split link outqueue Jon Maloy
2015-03-13 20:08 ` [PATCH net-next v2 7/7] tipc: clean up handling of message priorities Jon Maloy
2015-03-14 18:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314.143902.386608049896474304.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).