netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: venkat.x.venkatsubra@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: reset bridge mtu after deleting an interface
Date: Sat, 14 Mar 2015 19:12:56 -0400 (EDT)	[thread overview]
Message-ID: <20150314.191256.1947233794659640457.davem@davemloft.net> (raw)
In-Reply-To: <55039924.3050609@cumulusnetworks.com>

From: roopa <roopa@cumulusnetworks.com>
Date: Fri, 13 Mar 2015 19:12:52 -0700

> On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote:
>> On adding an interface br_add_if() sets the MTU to the min of
>> all the interfaces. Do the same thing on removing an interface too
>> in br_del_if.
>>
>> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
>> ---
>>   net/bridge/br_if.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
>> index b087d27..1849d96 100644
>> --- a/net/bridge/br_if.c
>> +++ b/net/bridge/br_if.c
>> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct
>> net_device *dev)
>>   	 */
>>   	del_nbp(p);
>>   +	dev_set_mtu(br->dev, br_min_mtu(br));
>> +
>>   	spin_lock_bh(&br->lock);
>>   	changed_addr = br_stp_recalculate_bridge_id(br);
>>   	spin_unlock_bh(&br->lock);
> This looks good to me.
> 
> Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Applied, thanks everyone.

      reply	other threads:[~2015-03-14 23:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 14:08 [PATCH] bridge: reset bridge mtu after deleting an interface Venkat Venkatsubra
2015-03-14  2:12 ` roopa
2015-03-14 23:12   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150314.191256.1947233794659640457.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=venkat.x.venkatsubra@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).