* [PATCH] bridge: reset bridge mtu after deleting an interface
@ 2015-03-13 14:08 Venkat Venkatsubra
2015-03-14 2:12 ` roopa
0 siblings, 1 reply; 3+ messages in thread
From: Venkat Venkatsubra @ 2015-03-13 14:08 UTC (permalink / raw)
To: netdev; +Cc: davem
On adding an interface br_add_if() sets the MTU to the min of
all the interfaces. Do the same thing on removing an interface too
in br_del_if.
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
---
net/bridge/br_if.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index b087d27..1849d96 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct net_device *dev)
*/
del_nbp(p);
+ dev_set_mtu(br->dev, br_min_mtu(br));
+
spin_lock_bh(&br->lock);
changed_addr = br_stp_recalculate_bridge_id(br);
spin_unlock_bh(&br->lock);
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: reset bridge mtu after deleting an interface
2015-03-13 14:08 [PATCH] bridge: reset bridge mtu after deleting an interface Venkat Venkatsubra
@ 2015-03-14 2:12 ` roopa
2015-03-14 23:12 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: roopa @ 2015-03-14 2:12 UTC (permalink / raw)
To: Venkat Venkatsubra; +Cc: netdev, davem
On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote:
> On adding an interface br_add_if() sets the MTU to the min of
> all the interfaces. Do the same thing on removing an interface too
> in br_del_if.
>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
> ---
> net/bridge/br_if.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index b087d27..1849d96 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct net_device *dev)
> */
> del_nbp(p);
>
> + dev_set_mtu(br->dev, br_min_mtu(br));
> +
> spin_lock_bh(&br->lock);
> changed_addr = br_stp_recalculate_bridge_id(br);
> spin_unlock_bh(&br->lock);
This looks good to me.
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: reset bridge mtu after deleting an interface
2015-03-14 2:12 ` roopa
@ 2015-03-14 23:12 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-03-14 23:12 UTC (permalink / raw)
To: roopa; +Cc: venkat.x.venkatsubra, netdev
From: roopa <roopa@cumulusnetworks.com>
Date: Fri, 13 Mar 2015 19:12:52 -0700
> On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote:
>> On adding an interface br_add_if() sets the MTU to the min of
>> all the interfaces. Do the same thing on removing an interface too
>> in br_del_if.
>>
>> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
>> ---
>> net/bridge/br_if.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
>> index b087d27..1849d96 100644
>> --- a/net/bridge/br_if.c
>> +++ b/net/bridge/br_if.c
>> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct
>> net_device *dev)
>> */
>> del_nbp(p);
>> + dev_set_mtu(br->dev, br_min_mtu(br));
>> +
>> spin_lock_bh(&br->lock);
>> changed_addr = br_stp_recalculate_bridge_id(br);
>> spin_unlock_bh(&br->lock);
> This looks good to me.
>
> Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-14 23:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 14:08 [PATCH] bridge: reset bridge mtu after deleting an interface Venkat Venkatsubra
2015-03-14 2:12 ` roopa
2015-03-14 23:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).