Re: [PATCH v4 1/3] can: kvaser_usb: Fix tx queue start/stop race conditions

Marc Kleine-Budde
2015-03-14T13:41:18Z

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On 03/14/2015 02:02 PM, Ahmed S. Darwish wrote:
> From: Ahmed S. Darwish <ahmed.darwish@valeo.com>
>
> A number of tx queue wake-up events went missing due to the
> outlined scenario below. Start state is a pool of 16 tx URBs,
> active tx_urbs count = 15, with the netdev tx queue open.
>
> CPU #1 [softirq] CPU #2 [softirq]
> start_xmit() tx_acknowledge()
> ................ ................
>
> atomic_inc(&tx_urbs);
> if (atomic_read(&tx_urbs) >= 16) {
> -->
> atomic_dec(&tx_urbs);
> netif_wake_queue();
> return;
> <--
> netif_stop_queue();
> }
>
> At the end, the correct state expected is a 15 tx_urbs count
> value with the tx queue state _open_. Due to the race, we get
> the same tx_urbs value but with the tx queue state _stopped_.
> The wake-up event is completely lost.
>
> Thus avoid hand-rolled concurrency mechanisms and use a proper
> lock for contexts and tx queue protection.
>
> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>

Applied to can. This will go into David's net tree and finally into
net-next. Then I'll apply patches 2+3. Nag me, if I forget about them ;)

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]