netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next 0/5] switchdev: add swdev ops
Date: Sun, 15 Mar 2015 20:00:29 -0400 (EDT)	[thread overview]
Message-ID: <20150315.200029.2060004791473258099.davem@davemloft.net> (raw)
In-Reply-To: <1426400107-6072-1-git-send-email-sfeldma@gmail.com>

From: sfeldma@gmail.com
Date: Sat, 14 Mar 2015 23:15:02 -0700

> From: Scott Feldman <sfeldma@gmail.com>
> 
> Per discussions at netconf, move switchdev ndo ops to a new swdev_ops to
> keep ndo namespace clean and maintain switchdev-related ops into one place.
> 
> There are no functional changes here; just shuffling ops around for better
> organization.

As Simon Horman mentioned, this series is not bisectable.

Someone trying to track down a bug in the switch code will
find that all the switch offloading stops happening after
patch #2.

You have to arrange these changes such that full functionality and no
regressions occur at each and every step of the patch seres.

Thanks.

      parent reply	other threads:[~2015-03-16  0:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15  6:15 [PATCH net-next 0/5] switchdev: add swdev ops sfeldma
2015-03-15  6:15 ` [PATCH net-next 1/5] " sfeldma
2015-03-15  6:15 ` [PATCH net-next 2/5] switchdev: use new " sfeldma
2015-03-15 23:44   ` Simon Horman
2015-03-16  0:43     ` Scott Feldman
2015-03-16  8:10       ` Simon Horman
2015-03-15  6:15 ` [PATCH net-next 3/5] rocker: move to " sfeldma
2015-03-15  6:15 ` [PATCH net-next 4/5] dsa: " sfeldma
2015-03-15  6:15 ` [PATCH net-next 5/5] netdev: remove ndo ops for switchdev sfeldma
2015-03-15 17:03 ` [PATCH net-next 0/5] switchdev: add swdev ops Jiri Pirko
2015-03-15 17:56   ` Scott Feldman
2015-03-16  0:00 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150315.200029.2060004791473258099.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).