From: Stephen Hemminger <stephen@networkplumber.org>
To: Tobias Stoeckmann <tobias@stoeckmann.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Avoid signal race in arpd initialization.
Date: Sun, 15 Mar 2015 12:25:15 -0700 [thread overview]
Message-ID: <20150315122515.1a164175@urahara> (raw)
In-Reply-To: <20150311205845.GA23722@localhost>
On Wed, 11 Mar 2015 21:58:45 +0100
Tobias Stoeckmann <tobias@stoeckmann.org> wrote:
> Signal handlers in arpd use siglongjmp() to return into main function
> during polls. The environment for the jumps is set after the signal
> handlers are installed. This leaves a small time frame in which an
> uninitialized environment could be used for a siglongjmp() call, leading
> to undefined behavior.
>
> While at it, define flag variables as sig_atomic_t instead of int.
I understand, but this is such a corner case. And you made several
other changes. Don't think it is worth doing this change.
You would have to signal arpd in the very small window between
the signal setup and the setjmp call.
prev parent reply other threads:[~2015-03-15 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 20:58 [PATCH] Avoid signal race in arpd initialization Tobias Stoeckmann
2015-03-15 19:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150315122515.1a164175@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@stoeckmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).