Re: [PATCH net-next v2 0/3] switchdev: support stp updates on stacked netdevices

[Jiri Pirko <jiri@resnulli.us>]

Fri, Mar 13, 2015 at 05:31:56PM CET, davem@davemloft.net wrote:
>From: roopa <roopa@cumulusnetworks.com>
>Date: Fri, 13 Mar 2015 06:25:24 -0700
>
>> David, if you mean not touch bond and team but have the switchdev
>> api do it transparently, yes, i had it that way initially.  And i do
>> liked it that way as well. But the feedback i received (during the
>> initial introduction of this for setlink/dellink) was to make it
>> explicit for each master.
>
>I think the concern is that we only want to do this for devices
>for which it is safe to "traverse" down like this.

Yes, that was my point. Also, some layered drivers might want to do some
individual magic, propagate on condition, etc. I think it is clearer
architecture. And also, you can see right away what is happening. By
doing the travelsal directly in switchdev code, that is in the shadow :/


>
>But frankly I cannot think of any layered device where we would
>not want to do this.
>
>Let's go back to the simple scheme where we unconditionally traverse
>and if we hit a problem case we'll figure out how to deal with it
>then, ok?