* [PATCH 1/2] [v2] net/fsl: fix a bug in xgmac_mdio
@ 2015-03-16 10:55 shh.xie
2015-03-16 20:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: shh.xie @ 2015-03-16 10:55 UTC (permalink / raw)
To: netdev, davem; +Cc: Shaohui Xie
From: Shaohui Xie <Shaohui.Xie@freescale.com>
There is a bug in xgmac_wait_until_done() which mdio_stat should be used
instead of mdio_data when checking if busy bit is cleared.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
changes for v2:
splitted from http://patchwork.ozlabs.org/patch/450392/
drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 3a83bc2..5f691f2 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -79,7 +79,7 @@ static int xgmac_wait_until_done(struct device *dev,
/* Wait till the MDIO write is complete */
timeout = TIMEOUT;
- while ((ioread32be(®s->mdio_data) & MDIO_DATA_BSY) && timeout) {
+ while ((ioread32be(®s->mdio_stat) & MDIO_STAT_BSY) && timeout) {
cpu_relax();
timeout--;
}
--
1.8.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] [v2] net/fsl: fix a bug in xgmac_mdio
2015-03-16 10:55 [PATCH 1/2] [v2] net/fsl: fix a bug in xgmac_mdio shh.xie
@ 2015-03-16 20:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-16 20:28 UTC (permalink / raw)
To: shh.xie; +Cc: netdev, Shaohui.Xie
From: <shh.xie@gmail.com>
Date: Mon, 16 Mar 2015 18:55:50 +0800
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
>
> There is a bug in xgmac_wait_until_done() which mdio_stat should be used
> instead of mdio_data when checking if busy bit is cleared.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> changes for v2:
> splitted from http://patchwork.ozlabs.org/patch/450392/
Applied to net-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-16 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 10:55 [PATCH 1/2] [v2] net/fsl: fix a bug in xgmac_mdio shh.xie
2015-03-16 20:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).