From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: richard.alpe@ericsson.com, jon.maloy@ericsson.com,
ying.xue@windriver.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next 3/3] tipc: add support for connect() on dgram/rdm sockets
Date: Wed, 18 Mar 2015 14:48:16 -0400 (EDT) [thread overview]
Message-ID: <20150318.144816.1470893128899579539.davem@davemloft.net> (raw)
In-Reply-To: <1426670263-30358-4-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Wed, 18 Mar 2015 10:17:43 +0100
> + } else if (unlikely(m->msg_namelen < sizeof(*dest)) ||
> + dest->family != AF_TIPC) {
This is not indented correctly.
The "dest->family" on the second line should start exactly at the first
column after the openning parenthesis of the if() statement on the
previous line.
prev parent reply other threads:[~2015-03-18 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 9:17 [PATCH net-next 0/3] tipc: small bugfix an support for datagram connect() erik.hugne
2015-03-18 9:17 ` [PATCH net-next 1/3] tipc: remove redundant call to tipc_node_remove_conn erik.hugne
2015-03-18 9:41 ` Ying Xue
2015-03-18 15:27 ` Jon Maloy
2015-03-18 9:17 ` [PATCH net-next 2/3] tipc: do not report -EHOSTUNREACH for failed local delivery erik.hugne
2015-03-18 9:41 ` Ying Xue
2015-03-18 15:28 ` Jon Maloy
2015-03-18 9:17 ` [PATCH net-next 3/3] tipc: add support for connect() on dgram/rdm sockets erik.hugne
2015-03-18 18:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318.144816.1470893128899579539.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).