From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH iproute2] tc: m_bpf: fix next arg selection after tc opcode Date: Wed, 18 Mar 2015 11:13:33 +0100 Message-ID: <20150318101333.GD1992@nanopsycho.orion> References: <1af5314868a14e738b049319dc2c21102134bc9b.1426669396.git.daniel@iogearbox.net> <20150318100023.GC1992@nanopsycho.orion> <55094D4E.4070101@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: stephen@networkplumber.org, jhs@mojatatu.com, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:33588 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755588AbbCRKNg (ORCPT ); Wed, 18 Mar 2015 06:13:36 -0400 Received: by wgbcc7 with SMTP id cc7so30818244wgb.0 for ; Wed, 18 Mar 2015 03:13:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55094D4E.4070101@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Mar 18, 2015 at 11:02:54AM CET, daniel@iogearbox.net wrote: >On 03/18/2015 11:00 AM, Jiri Pirko wrote: >>Wed, Mar 18, 2015 at 10:13:34AM CET, daniel@iogearbox.net wrote: >>>Next argument after the tc opcode/verdict is optional, using NEXT_ARG() >>>requires to have another argument after that one otherwise tc will bail >>>out. Therefore, we need to advance to the next argument manually as done >>>elsewhere. >>> >>>Fixes: 86ab59a6660f ("tc: add support for BPF based actions") >>>Signed-off-by: Daniel Borkmann >> >>Thanks for fixing this Daniel. > >Thanks & sorry I forgot to put you in Cc, I realized that too late. It happens, don't worry about that :) > >Lack of coffee. ;)