From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next] rhashtable: Warn if min_size or max_size are not a power of two
Date: Thu, 19 Mar 2015 15:24:50 -0400 (EDT) [thread overview]
Message-ID: <20150319.152450.1573636653085091157.davem@davemloft.net> (raw)
In-Reply-To: <29119e13cd16d4a98b4ed6806bec2683943bcd5f.1426782799.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 19 Mar 2015 17:34:39 +0100
> The current code correctly limits table size to the next power of two.
> This check is solely to catch programming errors.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
...
> + roundup_pow_of_two(params->min_size) != params->min_size);
Please use "!is_power_of_two()", thanks.
next prev parent reply other threads:[~2015-03-19 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 16:34 [PATCH net-next] rhashtable: Warn if min_size or max_size are not a power of two Thomas Graf
2015-03-19 19:24 ` David Miller [this message]
2015-03-19 19:46 ` [PATCH net-next v2] " Thomas Graf
2015-03-19 21:02 ` Herbert Xu
2015-03-19 21:15 ` Thomas Graf
2015-03-19 21:49 ` Herbert Xu
2015-03-19 22:02 ` Herbert Xu
2015-03-19 22:31 ` [PATCH net-next] rhashtable: Round up/down min/max_size to ensure we respect limit Thomas Graf
2015-03-19 22:41 ` Herbert Xu
2015-03-20 1:02 ` David Miller
2015-03-20 10:57 ` [PATCH net-next v2] rhashtable: Warn if min_size or max_size are not a power of two David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319.152450.1573636653085091157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).