From: David Miller <davem@davemloft.net>
To: markos.chandras@imgtec.com
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
pcnet32@frontier.com
Subject: Re: [PATCH v2] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}
Date: Fri, 20 Mar 2015 13:19:43 -0400 (EDT) [thread overview]
Message-ID: <20150320.131943.186301137261996820.davem@davemloft.net> (raw)
In-Reply-To: <1426760894-2677-1-git-send-email-markos.chandras@imgtec.com>
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 19 Mar 2015 10:28:14 +0000
> On a MIPS Malta board, tons of fifo underflow errors have been observed
> when using u-boot as bootloader instead of YAMON. The reason for that
> is that YAMON used to set the pcnet device to SRAM mode but u-boot does
> not. As a result, the default Tx threshold (64 bytes) is now too small to
> keep the fifo relatively used and it can result to Tx fifo underflow errors.
> As a result of which, it's best to setup the SRAM on supported controllers
> so we can always use the NOUFLO bit.
>
> Cc: <netdev@vger.kernel.org>
> Cc: <stable@vger.kernel.org>
> Cc: <linux-kernel@vger.kernel.org>
> Cc: Don Fry <pcnet32@frontier.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Applied.
prev parent reply other threads:[~2015-03-20 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 20:10 [PATCH] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5} Markos Chandras
2015-03-19 2:07 ` Don Fry
2015-03-19 8:37 ` Markos Chandras
2015-03-19 10:28 ` [PATCH v2] " Markos Chandras
2015-03-20 17:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320.131943.186301137261996820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).