From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, eric.dumazet@gmail.com, kaber@trash.net,
netdev@vger.kernel.org
Subject: Re: [v1 PATCH 0/7] rhashtable: Introduce inlined interface
Date: Fri, 20 Mar 2015 16:17:43 -0400 (EDT) [thread overview]
Message-ID: <20150320.161743.1329037804732884094.davem@davemloft.net> (raw)
In-Reply-To: <20150320105421.GA18148@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 20 Mar 2015 21:54:21 +1100
> This series of patches introduces the inlined rhashtable interface.
Series applied, thanks Herbert.
Why do you need that trailer[] think in the new netlink code?
You only use it in an offsetof() expression and wouldn't sizeof
the structure work just fine for that? This also makes the
memset() superfluous in the initializer function.
next prev parent reply other threads:[~2015-03-20 20:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 10:54 [v1 PATCH 0/7] rhashtable: Introduce inlined interface Herbert Xu
2015-03-20 10:56 ` [v1 PATCH 1/7] rhashtable: Make rhashtable_init params argument const Herbert Xu
2015-03-20 13:16 ` Thomas Graf
2015-03-20 10:57 ` [v1 PATCH 2/7] rhashtable: Allow hash/comparison functions to be inlined Herbert Xu
2015-03-20 11:20 ` Patrick McHardy
2015-03-20 12:02 ` Herbert Xu
2015-03-20 12:06 ` Patrick McHardy
2015-03-20 10:57 ` [v1 PATCH 3/7] netlink: Move namespace into hash key Herbert Xu
2015-03-20 10:57 ` [v1 PATCH 4/7] netfilter: Convert nft_hash to inlined rhashtable Herbert Xu
2015-03-20 10:57 ` [v1 PATCH 5/7] test_rhashtable: Use inlined rhashtable interface Herbert Xu
2015-03-20 10:57 ` [v1 PATCH 6/7] tipc: " Herbert Xu
2015-03-20 10:57 ` [v1 PATCH 7/7] rhashtable: Rip out obsolete out-of-line interface Herbert Xu
2015-03-20 20:25 ` Thomas Graf
2015-03-20 21:24 ` Herbert Xu
2015-03-20 20:17 ` David Miller [this message]
2015-03-20 21:28 ` [v1 PATCH 0/7] rhashtable: Introduce inlined interface Herbert Xu
2015-03-20 22:17 ` David Miller
2015-03-20 22:21 ` Herbert Xu
2015-03-20 22:37 ` David Miller
2015-03-21 3:14 ` Herbert Xu
2015-03-21 4:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320.161743.1329037804732884094.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).