Re: [net-next:master 925/931] include/linux/rhashtable.h:522:13: error: 'EEXIST' undeclared

Re: [net-next:master 925/931] include/linux/rhashtable.h:522:13: error: 'EEXIST' undeclared

[Herbert Xu]

On Sat, Mar 21, 2015 at 04:49:22AM +0800, kbuild test robot wrote:
>
> All error/warnings:
> 
>    In file included from net/tipc/socket.c:37:0:
>    include/linux/rhashtable.h: In function '__rhashtable_insert_fast':
> >> include/linux/rhashtable.h:522:13: error: 'EEXIST' undeclared (first use in this function)
>      int err = -EEXIST;

Thanks for the report, this should fix it:

---8<---
rhashtable: Fix undeclared EEXIST build error on ia64

We need to include linux/errno.h in rhashtable.h since it doesn't
always get included otherwise.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index e5b76cf..18a6488 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -18,6 +18,7 @@
 #define _LINUX_RHASHTABLE_H
 
 #include <linux/compiler.h>
+#include <linux/errno.h>
 #include <linux/list_nulls.h>
 #include <linux/workqueue.h>
 #include <linux/mutex.h>

-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [net-next:master 925/931] include/linux/rhashtable.h:522:13: error: 'EEXIST' undeclared

[David Miller]

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 21 Mar 2015 08:32:51 +1100

> rhashtable: Fix undeclared EEXIST build error on ia64
> 
> We need to include linux/errno.h in rhashtable.h since it doesn't
> always get included otherwise.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks.