From: Richard Cochran <richardcochran@gmail.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.com>,
tglx@linutronix.de, Arnd Bergmann <arnd@linaro.org>
Subject: Re: [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type
Date: Fri, 20 Mar 2015 07:26:03 +0100 [thread overview]
Message-ID: <20150320062603.GC4417@localhost.localdomain> (raw)
In-Reply-To: <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
On Fri, Mar 20, 2015 at 09:54:05AM +0800, Baolin Wang wrote:
> Next patch series will contain all of the drivers which need to be changed.
> But i think the conditional in ptp_clock.c can still in there.
Why?
> Because our plan is once all the drivers are converted, i will remove the
> conditional, along with the original function pointer.
> Is that OK? Thanks!
I want to avoid a patch series that introduces something, only to
remove it later on. Sometimes you have to do that way for a complex
transformation, but this case is rather simple.
You can change the gettime signature in one patch, and the settime in
a second patch.
Thanks,
Richard
next prev parent reply other threads:[~2015-03-20 6:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:45 [PATCH 0/4] Introduce another options to set/get time with "ktime_t" type Baolin Wang
2015-03-19 5:45 ` [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure Baolin Wang
2015-03-19 7:48 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Baolin Wang
2015-03-19 7:54 ` Richard Cochran
[not found] ` <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
2015-03-20 6:26 ` Richard Cochran [this message]
2015-03-20 13:43 ` Arnd Bergmann
2015-03-20 16:49 ` Richard Cochran
2015-03-21 1:16 ` Arnd Bergmann
2015-03-21 7:24 ` Richard Cochran
2015-03-21 16:52 ` Richard Cochran
2015-03-22 2:47 ` Arnd Bergmann
2015-03-21 9:21 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 3/4] ptp/pch:Replace timespec with ktime_t in ptp_pch.c Baolin Wang
2015-03-19 5:45 ` [PATCH 4/4] ptp/ixp46x:Replace timespec with ktime_t in ptp_ixp46x.c Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320062603.GC4417@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=arnd@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).