From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [v1 PATCH 7/14] netfilter: Use rhashtable_lookup instead of lookup_compare Date: Fri, 20 Mar 2015 22:36:13 +0000 Message-ID: <20150320223613.GD566@casper.infradead.org> References: <20150320095908.GG21258@acer.localdomain> <20150320101603.GA17662@gondor.apana.org.au> <20150320102701.GA28736@acer.localdomain> <20150320214712.GA23963@gondor.apana.org.au> <20150320215612.GA566@casper.infradead.org> <20150320215756.GA24045@gondor.apana.org.au> <20150320220751.GB566@casper.infradead.org> <20150320221021.GA24140@gondor.apana.org.au> <20150320222311.GC566@casper.infradead.org> <20150320222530.GA24309@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Patrick McHardy , David Miller , netdev@vger.kernel.org, Eric Dumazet To: Herbert Xu Return-path: Received: from casper.infradead.org ([85.118.1.10]:42648 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbbCTWgO (ORCPT ); Fri, 20 Mar 2015 18:36:14 -0400 Content-Disposition: inline In-Reply-To: <20150320222530.GA24309@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: On 03/21/15 at 09:25am, Herbert Xu wrote: > On Fri, Mar 20, 2015 at 10:23:11PM +0000, Thomas Graf wrote: > > > > He might as well just run for (;;) to burn cycles in his namespace. > > If you give away virtualized local privileges you better be ready > > to restrict the resources consumed. > > Please reread the first email that you replied to, let me quote: > > A CPU intensive workload that can be rescheduled is > completely different from one that is running under spin > lock with BH disabled. We have countless ways to create linear list of things like classifiers, qdiscs, multicast memberships, net_devices, fib_rules, etc. All taking spin locks or write locks. Most of them with BH disabled. Some at least use hashtables with most of them fixed size. I don't want to downplay this but do you *really* want to run untrusted workloads with CAP_NET_ADMIN privileges?