From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH net-next V2 04/23] ptp: blackfin: convert to the 64 bit get/set time methods. Date: Sun, 22 Mar 2015 08:27:34 +0100 Message-ID: <20150322072734.GA4254@localhost.localdomain> References: <201503220328.46415.arnd@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Vadai , Ariel Elior , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , Stefan =?iso-8859-1?Q?S=F8rensen?= Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:36118 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbbCVH1l (ORCPT ); Sun, 22 Mar 2015 03:27:41 -0400 Content-Disposition: inline In-Reply-To: <201503220328.46415.arnd@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Mar 22, 2015 at 03:28:46AM +0100, Arnd Bergmann wrote: > I think it would be good to replace the open-coded > > ns = ts->tv_sec * 1000000000ULL; > ns += ts->tv_nsec; > > here with a call to ns_to_timespec64(), here and in other drivers that you > are already touching. Yes, I'll do that as a follow on series. Thanks, Richard