From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: fengyuleidian0615@gmail.com, erik.hugne@ericsson.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] inet: fix double request socket freeing
Date: Mon, 23 Mar 2015 21:41:14 -0400 (EDT) [thread overview]
Message-ID: <20150323.214114.813876422885118707.davem@davemloft.net> (raw)
In-Reply-To: <1427148041.25985.80.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 23 Mar 2015 15:00:41 -0700
> From: Fan Du <fan.du@intel.com>
>
> Eric Hugne reported following error :
>
> I'm hitting this warning on latest net-next when i try to SSH into a machine
> with eth0 added to a bridge (but i think the problem is older than that)
>
> Steps to reproduce:
> node2 ~ # brctl addif br0 eth0
> [ 223.758785] device eth0 entered promiscuous mode
> node2 ~ # ip link set br0 up
> [ 244.503614] br0: port 1(eth0) entered forwarding state
> [ 244.505108] br0: port 1(eth0) entered forwarding state
...
> Remove the double calls to reqsk_put()
>
> [edumazet] :
>
> I got confused because reqsk_timer_handler() _has_ to call
> reqsk_put(req) after calling inet_csk_reqsk_queue_drop(), as
> the timer handler holds a reference on req.
>
> Signed-off-by: Fan Du <fan.du@intel.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Erik Hugne <erik.hugne@ericsson.com>
> Fixes: fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
Applied, thanks Eric.
prev parent reply other threads:[~2015-03-24 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 9:03 tcp_v4_err/request sock refcnt leak? Erik Hugne
2015-03-23 10:27 ` Fan Du
2015-03-23 11:15 ` Erik Hugne
2015-03-23 14:11 ` Eric Dumazet
2015-03-24 1:49 ` Fan Du
2015-03-24 2:03 ` Eric Dumazet
2015-03-23 17:06 ` [PATCH net-next] inet: fix double request socket freeing Eric Dumazet
2015-03-23 21:01 ` David Miller
2015-03-23 22:00 ` [PATCH v2 " Eric Dumazet
2015-03-24 1:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323.214114.813876422885118707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=erik.hugne@ericsson.com \
--cc=fengyuleidian0615@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).