From: Simon Horman <simon.horman@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Scott Feldman <sfeldma@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] rocker: handle non-bridge master change
Date: Mon, 23 Mar 2015 15:53:55 +0900 [thread overview]
Message-ID: <20150323065353.GA16565@vergenet.net> (raw)
In-Reply-To: <20150323062309.GA2032@nanopsycho.orion>
On Mon, Mar 23, 2015 at 07:23:09AM +0100, Jiri Pirko wrote:
> Mon, Mar 23, 2015 at 07:13:21AM CET, simon.horman@netronome.com wrote:
> >Master change notifications may occur other than when joining or
> >leaving a bridge, for example when being added to or removed from
> >a bond or Open vSwitch.
> >
> >Previously in those cases rocker_port_bridge_leave() was called
> >which results in a null-pointer dereference as rocker_port->bridge_dev
> >is NULL because there is no bridge device.
> >
> >This patch makes provision for doing nothing in such cases.
> >
> >Fixes: 6c7079450071f ("rocker: implement L2 bridge offloading")
> >Signed-off-by: Simon Horman <simon.horman@netronome.com>
>
> Acked-by: Jiri Pirko <jiri@resnulli.us>
I would like to clarify that I lightly tested this patch to the
extent that I no longer see a null-pointer dereference.
next prev parent reply other threads:[~2015-03-23 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 6:13 [PATCH net] rocker: handle non-bridge master change Simon Horman
2015-03-23 6:23 ` Jiri Pirko
2015-03-23 6:53 ` Simon Horman [this message]
2015-03-23 18:43 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323065353.GA16565@vergenet.net \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).