From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Amir Vadai" <amirv@mellanox.com>,
"Ariel Elior" <ariel.elior@qlogic.com>,
"Baolin Wang" <baolin.wang@linaro.org>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Bruce Allan" <bruce.w.allan@intel.com>,
"Carolyn Wyborny" <carolyn.wyborny@intel.com>,
"Chris Metcalf" <cmetcalf@ezchip.com>,
"David Miller" <davem@davemloft.net>,
"Frank Li" <Frank.Li@freescale.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"John Stultz" <john.stultz@linaro.org>,
"Luwei Zhou" <b45643@freescale.com>,
"Matthew Vick" <matthew.vick@intel.com>,
"Michael Chan" <mchan@broadcom.com>,
"Prashant Sreedharan" <prashant@broadcom.com>,
"Shradha Shah" <sshah@solarflare.com>,
"Solarflare linux maintainers" <linux-net-drivers@solarflare.com>,
"Sonic Zhang" <sonic.zhang@analog.com>,
"Stefan Sørensen" <stefan.sorensen@spectrali>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.
Date: Mon, 23 Mar 2015 09:10:40 +0100 [thread overview]
Message-ID: <20150323081040.GA4779@localhost.localdomain> (raw)
In-Reply-To: <201503221848.02226.arnd@linaro.org>
On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote:
> Ok, got it. The code looks correct then, though I'd like to see the use
> of 'timespec' pushed out as far as possible. How about changing the
> type for tdr_write() as well here?
>
> tdr_write() itself should be fine until 2106, as it writes an unsigned number,
> but it's probably good to document that inside of that function.
Arnd, thanks for the careful review. I will work out follow up
patches for this driver and the i210 (igb) to address the remaining
issues. For this series, lets leave tdr_write as is now, but I will
surely take another look for the fix.
Thanks,
Richard
next prev parent reply other threads:[~2015-03-23 8:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 21:39 [PATCH net-next V2 00/23] ptp: get ready for 2038 Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 01/23] ptp: introduce get/set time methods with explicit 64 bit seconds Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 02/23] ptp: use the 64 bit gettime method for the SYS_OFFSET ioctl Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 03/23] ptp: use the 64 bit get/set time methods for the posix clock Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 04/23] ptp: blackfin: convert to the 64 bit get/set time methods Richard Cochran
2015-03-22 2:28 ` Arnd Bergmann
2015-03-22 7:27 ` Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 05/23] ptp: xgbe: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 06/23] ptp: bnx2x: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 07/23] ptp: tg3: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 08/23] ptp: fec: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 09/23] ptp: gianfar: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 10/23] ptp: e1000e: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 11/23] ptp: fm10k: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 12/23] ptp: i40e: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 13/23] ptp: igb: " Richard Cochran
2015-03-22 2:40 ` Arnd Bergmann
2015-03-21 21:39 ` [PATCH net-next V2 14/23] ptp: ixgbe: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 15/23] ptp: mlx4: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 16/23] ptp: sfc: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 17/23] ptp: stmmac: " Richard Cochran
2015-03-23 15:35 ` Giuseppe CAVALLARO
2015-03-31 13:22 ` Rayagond Kokatanur
2015-03-21 21:39 ` [PATCH net-next V2 18/23] ptp: cpts: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 19/23] ptp: tilegx: " Richard Cochran
2015-03-23 16:02 ` Chris Metcalf
2015-03-23 16:58 ` Richard Cochran
2015-03-23 17:26 ` Chris Metcalf
2015-03-23 20:06 ` Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 20/23] ptp: dp83640: " Richard Cochran
2015-03-22 2:36 ` Arnd Bergmann
2015-03-22 7:29 ` Richard Cochran
2015-03-22 17:48 ` Arnd Bergmann
2015-03-23 8:10 ` Richard Cochran [this message]
2015-03-23 15:06 ` Arnd Bergmann
2015-03-21 21:39 ` [PATCH net-next V2 21/23] ptp: ixp46x: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 22/23] ptp: pch: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 23/23] ptp: remove 32 bit get/set methods Richard Cochran
2015-03-22 2:43 ` [PATCH net-next V2 00/23] ptp: get ready for 2038 Arnd Bergmann
2015-03-23 10:16 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323081040.GA4779@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=Frank.Li@freescale.com \
--cc=amirv@mellanox.com \
--cc=ariel.elior@qlogic.com \
--cc=arnd@linaro.org \
--cc=b45643@freescale.com \
--cc=baolin.wang@linaro.org \
--cc=ben@decadent.org.uk \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=cmetcalf@ezchip.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=matthew.vick@intel.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=prashant@broadcom.com \
--cc=sonic.zhang@analog.com \
--cc=sshah@solarflare.com \
--cc=stefan.sorensen@spectrali \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).