From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2 1/2] lib names: Split to db_names_alloc and db_names_load
Date: Tue, 24 Mar 2015 14:58:51 -0700 [thread overview]
Message-ID: <20150324145851.516ca7af@urahara> (raw)
In-Reply-To: <1426623342-16470-2-git-send-email-vadim4j@gmail.com>
On Tue, 17 Mar 2015 22:15:41 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> From: Vadim Kochan <vadim4j@gmail.com>
>
> Also added checking for malloc failing
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Conceptually I am fine with this, but it doesn't build:
tc_util.c: In function ‘cls_names_init’:
tc_util.c:40:14: error: too many arguments to function ‘db_names_alloc’
cls_names = db_names_alloc(path ?: NAMES_DB);
^
In file included from tc_util.c:26:0:
../include/names.h:19:18: note: declared here
struct db_names *db_names_alloc(void);
^
<builtin>: recipe for target 'tc_util.o' failed
make[1]: *** [tc_util.o] Error 1
All patches must build (even if split into two pieces).
next prev parent reply other threads:[~2015-03-24 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 20:15 [PATCH iproute2 v2 0/2] tc class names: Ignore if default file does not exist Vadim Kochan
2015-03-17 20:15 ` [PATCH iproute2 v2 1/2] lib names: Split to db_names_alloc and db_names_load Vadim Kochan
2015-03-24 21:58 ` Stephen Hemminger [this message]
2015-03-17 20:15 ` [PATCH iproute2 v2 2/2] tc class: Ignore if default class name file does not exist Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324145851.516ca7af@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox