From: Stephen Hemminger <stephen@networkplumber.org>
To: Philip Prindeville <philipp@redfish-solutions.com>
Cc: netdev@vger.kernel.org, Alexy Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH v2] iproute2: Fix -o (oneline) being broken in xfrm & correct mark radix
Date: Tue, 24 Mar 2015 15:02:18 -0700 [thread overview]
Message-ID: <20150324150218.42cb176d@urahara> (raw)
In-Reply-To: <20150319_195428_022337.philipp@redfish-solutions.com>
On Thu, 19 Mar 2015 13:54:28 -0600
Philip Prindeville <philipp@redfish-solutions.com> wrote:
> Don't insert newline in -o (oneline) mode; print mark as hex.
>
> Oneline mode is supposed to force all output to be on oneline and
> machine-parsable, but this isn't the case for "ip xfrm" as shown:
>
> % ip -o xfrm monitor
> ...
> src 0.0.0.0/0 dst 0.0.0.0/0 \ dir out priority 2051 ptype main \ mark -1879048191/0xffffffff
> tmpl src 203.0.130.10 dst 198.51.130.30\ proto esp reqid 16384 mode tunnel\
> ...
>
> as that's 2 lines, not one. Also, the "mark" is shown in signed
> decimal, but the mask is in hex. This is confusing: let's use
> hex for both.
>
> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Applied to master. Thanks
prev parent reply other threads:[~2015-03-24 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:54 [PATCH v2] iproute2: Fix -o (oneline) being broken in xfrm & correct mark radix Philip Prindeville
2015-03-24 22:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324150218.42cb176d@urahara \
--to=stephen@networkplumber.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=philipp@redfish-solutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).