From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH 1/5 net-next] rhashtable: Extend RCU read lock into rhashtable_insert_rehash()
Date: Tue, 24 Mar 2015 19:40:44 +0000 [thread overview]
Message-ID: <20150324194044.GD19251@casper.infradead.org> (raw)
In-Reply-To: <d12cd2734040e1cfb4fb04e78d51ec6c12a538c2.1427202823.git.tgraf@suug.ch>
On 03/24/15 at 02:18pm, Thomas Graf wrote:
> @@ -585,8 +585,8 @@ restart:
> if (unlikely(rht_grow_above_100(ht, tbl))) {
> slow_path:
> spin_unlock_bh(lock);
> - rcu_read_unlock();
> err = rhashtable_insert_rehash(ht);
> + rcu_read_unlock();
> if (err)
> return err;
An alternative would be to start a new RCU section inside
rhashtable_insert_rehash(). This was the easier fix but I'm
fine either way.
next prev parent reply other threads:[~2015-03-24 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 13:18 [PATCH 0/5 net-next] rhashtable updates on top of Herbert's work Thomas Graf
2015-03-24 13:18 ` [PATCH 1/5 net-next] rhashtable: Extend RCU read lock into rhashtable_insert_rehash() Thomas Graf
2015-03-24 19:40 ` Thomas Graf [this message]
2015-03-24 13:18 ` [PATCH 2/5 net-next] rhashtable: Use 'unsigned int' consistently Thomas Graf
2015-03-24 13:18 ` [PATCH 3/5 net-next] rhashtable: Mark internal/private inline functions as such Thomas Graf
2015-03-24 13:18 ` [PATCH 4/5 net-next] rhashtable: Disable automatic shrinking by default Thomas Graf
2015-03-24 18:55 ` Herbert Xu
2015-03-24 19:28 ` Thomas Graf
2015-03-24 19:29 ` David Miller
2015-03-24 20:42 ` [PATCH 4/5 net-next v2] " Thomas Graf
2015-03-24 22:01 ` David Miller
2015-03-24 13:18 ` [PATCH 5/5 net-next] rhashtable: Add rhashtable_free_and_destroy() Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324194044.GD19251@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).