From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: fix ipv4 mapped request socks
Date: Tue, 24 Mar 2015 22:48:38 -0700 [thread overview]
Message-ID: <20150325054837.GA790@localhost.westell.com> (raw)
In-Reply-To: <1427260862.25985.105.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Mar 24, 2015 at 10:21:02PM -0700, Eric Dumazet wrote:
> On Wed, 2015-03-25 at 00:57 -0400, David Miller wrote:
>
> > Applied, thanks Eric.
> >
> > Please put the Fixes: tag before all the signoffs and acks
> > in the future, thanks in advance.
>
> Sure, I will try to remember this rule ;)
btw, the following time saving steps were useful to me:
1. add to your ~/.gitconfig
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
2. when bad commit is found do:
$ git log -1 --pretty=fixes 3f66b083a5b7f1a63540c24df3679c24f
which will print:
Fixes: 3f66b083a5b7 ("inet: introduce ireq_family")
3. copy-paste that line into your patch
next prev parent reply other threads:[~2015-03-25 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 4:45 [PATCH net-next] tcp: fix ipv4 mapped request socks Eric Dumazet
2015-03-25 4:57 ` David Miller
2015-03-25 5:21 ` Eric Dumazet
2015-03-25 5:48 ` Alexei Starovoitov [this message]
2015-03-25 16:48 ` Eric Dumazet
2015-03-26 16:37 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325054837.GA790@localhost.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).