netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Varun Prakash <varun@chelsio.com>
Cc: kbuild-all@01.org, Hariprasad S <hariprasad@chelsio.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cxgb4: fix boolreturn.cocci warnings
Date: Thu, 26 Mar 2015 05:55:25 +0800	[thread overview]
Message-ID: <20150325215525.GA26868@athens> (raw)
In-Reply-To: <201503260524.AdqSbov9%fengguang.wu@intel.com>

drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c:49:9-10: WARNING: return of 0/1 in function 'cxgb_fcoe_sof_eof_supported' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Varun Prakash <varun@chelsio.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 cxgb4_fcoe.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
@@ -46,17 +46,17 @@ bool cxgb_fcoe_sof_eof_supported(struct
 
 	if ((sof != FC_SOF_I3) && (sof != FC_SOF_N3)) {
 		dev_err(adap->pdev_dev, "Unsupported SOF 0x%x\n", sof);
-		return 0;
+		return false;
 	}
 
 	skb_copy_bits(skb, skb->len - 4, &eof, 1);
 
 	if ((eof != FC_EOF_N) && (eof != FC_EOF_T)) {
 		dev_err(adap->pdev_dev, "Unsupported EOF 0x%x\n", eof);
-		return 0;
+		return false;
 	}
 
-	return 1;
+	return true;
 }
 
 /**

       reply	other threads:[~2015-03-25 21:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201503260524.AdqSbov9%fengguang.wu@intel.com>
2015-03-25 21:55 ` kbuild test robot [this message]
2015-03-25 22:14   ` [PATCH] cxgb4: fix boolreturn.cocci warnings Joe Perches
2015-03-29 19:16   ` David Miller
2015-03-30  1:25     ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Joe Perches
2015-03-30  1:29       ` [PATCH net-next] wireless: " Joe Perches
2015-03-30  1:46         ` Larry Finger
2015-03-30  1:49           ` Joe Perches
2015-04-07 17:11         ` [net-next] wireless: Use bool function returns of true/false insteadof 1/0 Kalle Valo
2015-03-30 20:28       ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Jeff Kirsher
2015-03-31 11:10       ` Michal Simek
2015-03-31 19:49         ` Joe Perches
2015-03-31 18:10       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325215525.GA26868@athens \
    --to=fengguang.wu@intel.com \
    --cc=hariprasad@chelsio.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=varun@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).