From: Thomas Graf <tgraf@suug.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
jesse@nicira.com
Subject: Re: [patch net-next] tc: introduce OpenFlow classifier
Date: Thu, 26 Mar 2015 13:25:32 +0000 [thread overview]
Message-ID: <20150326132532.GB20404@casper.infradead.org> (raw)
In-Reply-To: <1427374439-11587-1-git-send-email-jiri@resnulli.us>
On 03/26/15 at 01:53pm, Jiri Pirko wrote:
> This patch introduces OpenFlow-based filter. So far, the very essential
> packet fields are supported (according to OpenFlow v1.4 spec).
>
> This patch is only the first step. There is a lot of potential performance
> improvements possible to implement. Also a lot of features are missing
> now. They will be addressed in follow-up patches.
>
> To the name of this classifier, I believe that "cls_openflow" is pretty
> accurate. It is actually a OpenFlow classifier.
My feedback on this was that this could be misleading because
cls_openflow does not make the kernel an OpenFlow switch (neither
does OVS). I can see the relation to some of the match fields as
specified by OpenFlow but there is no relation to the wire protocol
itself or any of the other OpenFlow specific concepts such as flow
tables, group tables, counters, actions, etc.
That said, I can see what you mean by it and I think if we make this
clear in the description and manual page that might be enough to
avoid confusion.
next prev parent reply other threads:[~2015-03-26 13:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 12:53 [patch net-next] tc: introduce OpenFlow classifier Jiri Pirko
2015-03-26 12:55 ` [patch iproute2/net-next] tc: add support for " Jiri Pirko
2015-03-26 13:25 ` Thomas Graf [this message]
2015-03-26 14:22 ` [patch net-next] tc: introduce " Jiri Pirko
2015-03-26 14:23 ` Hannes Frederic Sowa
2015-03-26 15:29 ` Jiri Pirko
2015-03-26 20:39 ` Hannes Frederic Sowa
2015-03-26 20:51 ` Daniel Borkmann
2015-03-27 6:07 ` Jiri Pirko
2015-03-27 11:44 ` Thomas Graf
2015-03-27 12:28 ` Jiri Pirko
2015-03-27 12:36 ` Thomas Graf
2015-03-27 12:45 ` Jiri Pirko
2015-03-27 12:49 ` Thomas Graf
2015-03-30 0:45 ` Jamal Hadi Salim
2015-03-30 0:39 ` Jamal Hadi Salim
2015-03-30 6:26 ` Jiri Pirko
2015-03-30 11:10 ` Jamal Hadi Salim
2015-03-30 12:18 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326132532.GB20404@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).