Re: [RFC net-next 1/2] net: allow user to set IPv6 nexthop for IPv4 route

Andy Gospodarek
2015-03-27T14:11:09Z

On Fri, Mar 27, 2015 at 11:53:01AM +0000, Robert Shearman wrote:
> On 26/03/15 21:05, Andy Gospodarek wrote:
> >diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> >index bea910f..26cdd01 100644
> >--- a/include/uapi/linux/rtnetlink.h
> >+++ b/include/uapi/linux/rtnetlink.h
> >@@ -306,6 +306,7 @@ enum rtattr_type_t {
> > RTA_VIA,
> > RTA_NEWDST,
> > RTA_PREF,
> >+ RTA_GATEWAY6,
>
> There shouldn't be any need to add a new attribute. The RTA_VIA attribute
> that Eric Biederman recently introduced should have the semantics that you
> require:
>
> "RTA_VIA specifies the specifies the next machine to send a packet to
> like RTA_GATEWAY. RTA_VIA differs from RTA_GATEWAY in that it
> includes the address family of the address of the next machine to send
> a packet to."

Absolutely. I did this first set before Eric added the RTA_VIA
attribute, so I need to not only use it, but also add support in the
ipv4 code to use that attribute if set.