From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Hyong-Youb Kim <hkim@cspi.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de,
hpa@zytor.com, jgross@suse.com, JBeulich@suse.com, bp@suse.de,
suresh.b.siddha@intel.com, venkatesh.pallipadi@intel.com,
airlied@redhat.com, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Hyong-Youb Kim <hykim@myri.com>,
netdev@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add()
Date: Fri, 27 Mar 2015 21:36:46 +0100 [thread overview]
Message-ID: <20150327203646.GN5622@wotan.suse.de> (raw)
In-Reply-To: <20150321070759.GB8766@gtest01.arcus>
On Sat, Mar 21, 2015 at 04:08:00PM +0900, Hyong-Youb Kim wrote:
> On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >
> > This driver already uses ioremap_wc() on the same range
> > so when write-combining is available that will be used
> > instead.
> >
> [...]
> > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
> > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
> [...]
> > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev,
> > data[i] = ((u64 *)&link_stats)[i];
> >
> > data[i++] = (unsigned int)mgp->tx_boundary;
> > - data[i++] = (unsigned int)mgp->wc_enabled;
> > data[i++] = (unsigned int)mgp->pdev->irq;
> > data[i++] = (unsigned int)mgp->msi_enabled;
> > data[i++] = (unsigned int)mgp->msix_enabled;
>
> You would have to delete "WC from myri10ge_gstrings_main_stats too.
> Something like below. Thanks.
>
> @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = {
> "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors",
> "tx_heartbeat_errors", "tx_window_errors",
> /* device-specific stats */
> - "tx_boundary", "WC", "irq", "MSI", "MSIX",
> + "tx_boundary", "irq", "MSI", "MSIX",
> "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs",
> "serial_number", "watchdog_resets",
> #ifdef CONFIG_MYRI10GE_DCA
OK great thanks. Amended.
Luis
prev parent reply other threads:[~2015-03-27 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com>
2015-03-20 23:18 ` [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Luis R. Rodriguez
2015-03-21 7:08 ` Hyong-Youb Kim
2015-03-27 20:36 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327203646.GN5622@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=JBeulich@suse.com \
--cc=adaplas@gmail.com \
--cc=airlied@redhat.com \
--cc=bp@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=hkim@cspi.com \
--cc=hpa@zytor.com \
--cc=hykim@myri.com \
--cc=jgross@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).