From: Jiri Benc <jbenc@redhat.com>
To: Mahesh Bandewar <maheshb@google.com>
Cc: linux-netdev <netdev@vger.kernel.org>, Dan Williams <dcbw@redhat.com>
Subject: Re: [PATCH net 1/4 v2] ipvlan: fix addr hash list corruption
Date: Sat, 28 Mar 2015 19:17:06 +0100 [thread overview]
Message-ID: <20150328191706.540f0cfc@griffin> (raw)
In-Reply-To: <CAF2d9jj-kkmwwJvVe8EjZcnGiy5roEUYh2AqX1Ov3FRNbtXNEw@mail.gmail.com>
On Fri, 27 Mar 2015 17:16:49 -0700, Mahesh Bandewar wrote:
> On Fri, Mar 27, 2015 at 10:30 AM, Jiri Benc <jbenc@redhat.com> wrote:
> > void ipvlan_ht_addr_del(struct ipvl_addr *addr, bool sync)
> > {
> > - hlist_del_rcu(&addr->hlnode);
> > + hlist_del_init_rcu(&addr->hlnode);
> Though this fixes the current crash problem; the duplicate addition in
> the hash-table is still open. I would still prefer it to be protected
> by hlist_unhashed() check.
It cannot happen but whatever, there's no harm in such check. Just sent
a new version.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-03-28 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 17:30 [PATCH net 0/4] ipvlan: list corruption and rcu fixes Jiri Benc
2015-03-27 17:30 ` [PATCH net 1/4 v2] ipvlan: fix addr hash list corruption Jiri Benc
2015-03-27 17:36 ` Sergei Shtylyov
2015-03-28 0:16 ` Mahesh Bandewar
2015-03-28 18:17 ` Jiri Benc [this message]
2015-03-29 19:23 ` David Miller
2015-03-27 17:30 ` [PATCH net 2/4] ipvlan: protect against concurrent link removal Jiri Benc
2015-03-27 17:30 ` [PATCH net 3/4] ipvlan: do not use rcu operations for address list Jiri Benc
2015-03-27 17:30 ` [PATCH net 4/4] ipvlan: fix check for IP addresses in control path Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150328191706.540f0cfc@griffin \
--to=jbenc@redhat.com \
--cc=dcbw@redhat.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).