* [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add()
@ 2015-03-26 23:20 Haiyang Zhang
2015-03-29 20:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Haiyang Zhang @ 2015-03-26 23:20 UTC (permalink / raw)
To: davem, netdev
Cc: haiyangz, kys, olaf, jasowang, linux-kernel, driverdev-devel
The vmbus_are_subchannels_present() also involves opening the channels, which
may be too early at this point. Checking for subchannels is not necessary here.
So this patch removes it. Subchannels will be opened when offer messages arrive.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/hyperv/rndis_filter.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index a2b185a..fdfab1f 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -1141,8 +1141,6 @@ int rndis_filter_device_add(struct hv_device *dev,
net_device->num_chn = 1 +
init_packet->msg.v5_msg.subchn_comp.num_subchannels;
- vmbus_are_subchannels_present(dev->channel);
-
ret = rndis_filter_set_rss_param(rndis_device, net_device->num_chn);
out:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add()
2015-03-26 23:20 [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add() Haiyang Zhang
@ 2015-03-29 20:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-29 20:15 UTC (permalink / raw)
To: haiyangz; +Cc: olaf, netdev, jasowang, driverdev-devel, linux-kernel
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Thu, 26 Mar 2015 16:20:58 -0700
> The vmbus_are_subchannels_present() also involves opening the channels, which
> may be too early at this point. Checking for subchannels is not necessary here.
> So this patch removes it. Subchannels will be opened when offer messages arrive.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-29 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 23:20 [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add() Haiyang Zhang
2015-03-29 20:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).