From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
Nikolay Aleksandrov <nikolay@redhat.com>,
David Miller <davem@davemloft.net>,
Maciej Zenczykowski <maze@google.com>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] bonding: Remove hardcoded initialization
Date: Mon, 30 Mar 2015 10:25:09 -0400 [thread overview]
Message-ID: <20150330142447.GK1051@gospo> (raw)
In-Reply-To: <1427520871-29869-1-git-send-email-maheshb@google.com>
On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
I realize that the changelog would be identical to the title, so
probably not critical here, but please add one whenever possible.
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> ---
> drivers/net/bonding/bond_3ad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 3cce25818b57..48f3bd7e2350 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
>
> port->is_enabled = true;
> /* private parameters */
> - port->sm_vars = 0x3;
> + port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
> port->sm_rx_state = 0;
> port->sm_rx_timer_counter = 0;
> port->sm_periodic_state = 0;
> --
> 2.2.0.rc0.207.ga3a616c
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-30 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 5:34 [PATCH net-next] bonding: Remove hardcoded initialization Mahesh Bandewar
2015-03-30 14:25 ` Andy Gospodarek [this message]
2015-03-30 17:07 ` Cong Wang
2015-03-31 17:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330142447.GK1051@gospo \
--to=gospo@cumulusnetworks.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox