[PATCH 0/7] drivers: Use bool function return values true/false not 1/0

[PATCH 0/7] drivers: Use bool function return values true/false not 1/0

[Joe Perches]

Joe Perches (7):
  drm: Use bool function return values of true/false not 1/0
  dm_table: Use bool function return values of true/false not 1/0
  genwqe: Use bool function return values of true/false not 1/0
  wmi: Use bool function return values of true/false not 1/0
  ssb: Use bool function return values of true/false not 1/0
  thermal: Use bool function return values of true/false not 1/0
  serial: kgdb_nmi: Use bool function return values of true/false not
    1/0

 drivers/gpu/drm/ast/ast_post.c        |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c |  2 +-
 drivers/md/dm-table.c                 | 20 ++++++++++----------
 drivers/misc/genwqe/card_base.h       |  2 +-
 drivers/platform/x86/wmi.c            |  4 ++--
 drivers/ssb/driver_gige.c             |  2 +-
 drivers/thermal/thermal_core.h        |  2 +-
 drivers/tty/serial/kgdb_nmi.c         |  6 +++---
 8 files changed, 20 insertions(+), 20 deletions(-)

-- 
2.1.2

[PATCH 5/7] ssb: Use bool function return values of true/false not 1/0

[Joe Perches]

Use the normal return values for bool functions

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/ssb/driver_gige.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
index e973405..ebee6b0 100644
--- a/drivers/ssb/driver_gige.c
+++ b/drivers/ssb/driver_gige.c
@@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
 bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
 {
 	if (!pdev->resource[0].name)
-		return 0;
+		return false;
 	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
 }
 EXPORT_SYMBOL(pdev_is_ssb_gige_core);
-- 
2.1.2

Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0

[Michael Büsch]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On Mon, 30 Mar 2015 10:43:21 -0700
Joe Perches <joe@perches.com> wrote:

> Use the normal return values for bool functions
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/ssb/driver_gige.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
> index e973405..ebee6b0 100644
> --- a/drivers/ssb/driver_gige.c
> +++ b/drivers/ssb/driver_gige.c
> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
>  bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
>  {
>  	if (!pdev->resource[0].name)
> -		return 0;
> +		return false;
>  	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
>  }
>  EXPORT_SYMBOL(pdev_is_ssb_gige_core);

Looks good.

Signed-off-by: Michael Buesch <m@bues.ch>

Kalle, can you take this one, please?

-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0

[Kalle Valo]

Michael Büsch <m@bues.ch> writes:

> On Mon, 30 Mar 2015 10:43:21 -0700
> Joe Perches <joe@perches.com> wrote:
>
>> Use the normal return values for bool functions
>> 
>> Signed-off-by: Joe Perches <joe@perches.com>
>> ---
>>  drivers/ssb/driver_gige.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
>> index e973405..ebee6b0 100644
>> --- a/drivers/ssb/driver_gige.c
>> +++ b/drivers/ssb/driver_gige.c
>> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
>>  bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
>>  {
>>  	if (!pdev->resource[0].name)
>> -		return 0;
>> +		return false;
>>  	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
>>  }
>>  EXPORT_SYMBOL(pdev_is_ssb_gige_core);
>
> Looks good.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
>
> Kalle, can you take this one, please?

Sure, I'll apply it in the next few days.

-- 
Kalle Valo