Re: [PATCH net-next 0/4] netlink: access functions for IP address attributes

[David Miller <davem@davemloft.net>]

From: Jiri Benc <jbenc@redhat.com>
Date: Sun, 29 Mar 2015 16:59:22 +0200

> There are many places that read or write IP addresses to netlink attributes.
> With IPv6 addresses, every such place currently has to use generic nla_put
> and nla_memcpy. Implementing IPv6 address access functions simplify things
> and makes the code more intelligible. IPv4 address access functions has
> lesser value but it would be better to be consistent between IPv6 and IPv4
> and they still serve as documentation.
> 
> The conversion is straightforward and the resulting patches are not that
> large, thus I kept all the changes in the patches that introduce the access
> functions. If anyone prefers to split the definition of access functions and
> the conversion and/or break it out by network protocols, please let me know.
> 
> While doing the conversion, I came across ugly typecasting in
> inetpeer_addr_base and xfrm_address_t when dealing with IPv6 addresses.
> Instead of introducing more of this, I cleaned it up. Those are the first
> two patches, serving as a prerequisite to the latter two.

Looks good, series applied, thanks Jiri.