From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: festevam@gmail.com, netdev@vger.kernel.org, fabio.estevam@freescale.com
Subject: Re: [PATCH net-next] net: smc91x: Remove an unused variable
Date: Tue, 31 Mar 2015 19:38:01 +0200 [thread overview]
Message-ID: <20150331173800.GJ17728@pengutronix.de> (raw)
In-Reply-To: <20150331.105328.2195438658331769456.davem@davemloft.net>
On Tue, Mar 31, 2015 at 10:53:28AM -0400, David Miller wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date: Mon, 30 Mar 2015 19:20:57 +0200
>
> > On Mon, Mar 30, 2015 at 01:43:38PM -0300, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Commit cb6e0b3690f48dff ("net: smc91x: make use of 4th parameter to devm_gpiod_get_index")
> >> caused the following build warning:
> >>
> >> drivers/net/ethernet/smsc/smc91x.c:2208:6: warning: unused variable 'res' [-Wunused-variable]
> >>
> >> Remove the unused 'res' variable.
> >>
> >> Reported-by: Olof's autobuilder <build@lixom.net>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > I wonder why I didn't notice this because the 0day build robot tested my
> > tree and didn't report this warning. Probably that means this driver
> > wasn't tested.
>
> This driver can't be enabled on x86/x86-64 so the build testing it will
> get is going to be extremely limited.
The build bot also builds other archs, at least arm and powerpc, but I
think there are more.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-03-31 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 16:43 [PATCH net-next] net: smc91x: Remove an unused variable Fabio Estevam
2015-03-30 17:20 ` Uwe Kleine-König
2015-03-31 14:53 ` David Miller
2015-03-31 17:38 ` Uwe Kleine-König [this message]
2015-03-31 20:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331173800.GJ17728@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).