From: Richard Cochran <richardcochran@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"baolin.wang@linaro.org" <baolin.wang@linaro.org>,
"b45643@freescale.com" <b45643@freescale.com>,
"sshah@solarflare.com" <sshah@solarflare.com>,
"amirv@mellanox.com" <amirv@mellanox.com>,
"ben@decadent.org.uk" <ben@decadent.org.uk>,
"sonic.zhang@analog.com" <sonic.zhang@analog.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"rayagond@vayavyalabs.com" <rayagond@vayavyalabs.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"ariel.elior@qlogic.com" <ariel.elior@qlogic.com>,
"cmetcalf@ezchip.com" <cmetcalf@ezchip.com>,
"Vick, Matthew" <matthew.vick@intel.com>,
"linux-net-drivers@solarflare.com"
<linux-net-drivers@solarflare.com>,
"arnd@linaro.org" <arnd@linaro.org>,
"Frank.Li@freescale.com" <Frank.Li@frees
Subject: Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods.
Date: Tue, 31 Mar 2015 23:37:07 +0200 [thread overview]
Message-ID: <20150331213707.GA9139@localhost.localdomain> (raw)
In-Reply-To: <1427836090.16312.27.camel@intel.com>
On Tue, Mar 31, 2015 at 09:08:10PM +0000, Keller, Jacob E wrote:
> On Sun, 2015-03-29 at 23:12 +0200, Richard Cochran wrote:
> > For the 82576, the driver's clock is implemented using a timecounter,
> > and so with this patch that device is ready for the year 2038.
> >
> > However, in the case of the i210, the device stores the number of
> > seconds in a 32 bit register. Therefore, more work is needed on this
> > driver before the year 2038 comes around.
> >
> > Compile tested only.
>
> I assume we would want to use a time counter wrapper here to resolve
> this issue?
I would just keep the seconds in software for settime() and adjtime(),
but let the nanoseconds field go to the hardware. Then, the gettime()
result, the periodic outputs, the external time stamps, and the skb
time stamps will need to be corrected by that many seconds.
Thanks,
Richard
next prev parent reply other threads:[~2015-03-31 21:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 21:11 [PATCH net-next V3 00/23] ptp: get ready for 2038 Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 01/23] ptp: introduce get/set time methods with explicit 64 bit seconds Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 02/23] ptp: use the 64 bit gettime method for the SYS_OFFSET ioctl Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 03/23] ptp: use the 64 bit get/set time methods for the posix clock Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 04/23] ptp: blackfin: convert to the 64 bit get/set time methods Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 05/23] ptp: xgbe: " Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 06/23] ptp: bnx2x: " Richard Cochran
2015-03-30 21:13 ` Sony Chacko
2015-03-29 21:11 ` [PATCH net-next V3 07/23] ptp: tg3: " Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 08/23] ptp: fec: " Richard Cochran
2015-03-29 21:11 ` [PATCH net-next V3 09/23] ptp: gianfar: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 10/23] ptp: e1000e: " Richard Cochran
2015-03-31 21:48 ` Richard Cochran
2015-03-31 23:26 ` David Miller
2015-03-29 21:12 ` [PATCH net-next V3 11/23] ptp: fm10k: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 12/23] ptp: i40e: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 13/23] ptp: igb: " Richard Cochran
2015-03-31 21:08 ` Keller, Jacob E
2015-03-31 21:37 ` Richard Cochran [this message]
2015-04-02 0:08 ` Keller, Jacob E
2015-03-31 21:53 ` Richard Cochran
2015-04-02 0:06 ` Keller, Jacob E
2015-04-02 6:33 ` Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 14/23] ptp: ixgbe: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 15/23] ptp: mlx4: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 16/23] ptp: sfc: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 17/23] ptp: stmmac: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 18/23] ptp: cpts: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 19/23] ptp: tilegx: " Richard Cochran
2015-03-29 21:32 ` Chris Metcalf
2015-03-29 21:12 ` [PATCH net-next V3 20/23] ptp: dp83640: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 21/23] ptp: ixp46x: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 22/23] ptp: pch: " Richard Cochran
2015-03-29 21:12 ` [PATCH net-next V3 23/23] ptp: remove 32 bit get/set methods Richard Cochran
2015-03-31 16:01 ` [PATCH net-next V3 00/23] ptp: get ready for 2038 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331213707.GA9139@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=Frank.Li@frees \
--cc=amirv@mellanox.com \
--cc=ariel.elior@qlogic.com \
--cc=arnd@linaro.org \
--cc=b45643@freescale.com \
--cc=baolin.wang@linaro.org \
--cc=ben@decadent.org.uk \
--cc=bruce.w.allan@intel.com \
--cc=cmetcalf@ezchip.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=matthew.vick@intel.com \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=sonic.zhang@analog.com \
--cc=sshah@solarflare.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).