From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linus.walleij@linaro.org, acourbot@nvidia.com,
kernel@pengutronix.de
Subject: Re: [PATCH v2] net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument
Date: Wed, 1 Apr 2015 09:00:01 +0200 [thread overview]
Message-ID: <20150401070001.GP17728@pengutronix.de> (raw)
In-Reply-To: <20150331.192838.1922058179914527422.davem@davemloft.net>
On Tue, Mar 31, 2015 at 07:28:38PM -0400, David Miller wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date: Tue, 31 Mar 2015 22:08:45 +0200
>
> > I still think assigning directly to priv->gpiod_reset would fine
> > because having the priv->gpiod_reset NULL is neither more nor less
> > right that ERR_PTR(-ESOMETHING).
>
> You really want to push my buttons don't you? :-/
>
> What if someone adds a new resource allocation after this thing and
> then adds an unwind path where something has to be done to the GPIOD
> as part of cleanup?
As I assume that v2 still addresses your concerns it would be ok for me
to not fully agree with you about defensive coding style.
What about you?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-04-01 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 20:08 [PATCH v2] net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument Uwe Kleine-König
2015-03-31 23:28 ` David Miller
2015-04-01 7:00 ` Uwe Kleine-König [this message]
2015-04-01 16:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401070001.GP17728@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=acourbot@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).