netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ethtool: git tree not updated to v3.18
@ 2015-04-01 21:30 Jesse Brandeburg
  2015-04-02  9:50 ` Daniel Borkmann
  2015-04-02 18:23 ` Ben Hutchings
  0 siblings, 2 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2015-04-01 21:30 UTC (permalink / raw)
  To: netdev, bwh; +Cc: jesse.brandeburg

Hi Ben, 

When trying to check a bug just now I noticed that the master
branch of
git://git.kernel.org/pub/scm/network/ethtool/ethtool

still points to the v3.16 tag.

But kernel.org shows version 3.18 released.  I did some quick
investigation and it looks like the v3.18 tag points to a dangling
commit that is not on a branch.

$ git log --graph --oneline v3.18 |head -n5
* ba9a11a Release version 3.18.
* 1e8811a Fix build with musl by using more common typedefs
* 99bc878 bug fix: SFP Tx BIAS uses memory wrong offset
* 4614098 Release version 3.16.
* 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing

$ git log --graph --oneline origin/master |head -n5
* 4614098 Release version 3.16.
* 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing
* 86c0326 ethtool: Support for configurable RSS hash key
* e633626 ethtool-copy.h: sync with net
* 05b8ad5 Release version 3.14.

Maybe you can merge the commits from your working branch back onto
master and make another 3.18.1 tag or something.

I just did:
git checkout master
git merge v3.18

which worked okay, I think.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ethtool: git tree not updated to v3.18
  2015-04-01 21:30 ethtool: git tree not updated to v3.18 Jesse Brandeburg
@ 2015-04-02  9:50 ` Daniel Borkmann
  2015-04-02 18:23 ` Ben Hutchings
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2015-04-02  9:50 UTC (permalink / raw)
  To: Jesse Brandeburg, netdev, bwh, davem

On 04/01/2015 11:30 PM, Jesse Brandeburg wrote:
> Hi Ben,
>
> When trying to check a bug just now I noticed that the master
> branch of
> git://git.kernel.org/pub/scm/network/ethtool/ethtool
>
> still points to the v3.16 tag.
>
> But kernel.org shows version 3.18 released.  I did some quick
> investigation and it looks like the v3.18 tag points to a dangling
> commit that is not on a branch.
>
> $ git log --graph --oneline v3.18 |head -n5
> * ba9a11a Release version 3.18.
> * 1e8811a Fix build with musl by using more common typedefs
> * 99bc878 bug fix: SFP Tx BIAS uses memory wrong offset
> * 4614098 Release version 3.16.
> * 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing
>
> $ git log --graph --oneline origin/master |head -n5
> * 4614098 Release version 3.16.
> * 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing
> * 86c0326 ethtool: Support for configurable RSS hash key
> * e633626 ethtool-copy.h: sync with net
> * 05b8ad5 Release version 3.14.
>
> Maybe you can merge the commits from your working branch back onto
> master and make another 3.18.1 tag or something.
>
> I just did:
> git checkout master
> git merge v3.18
>
> which worked okay, I think.

Btw, are there any plans to keep track of ethtool patches in
netdev patchwork as well, like we do with iproute2?

I recall in early January this year there was a patch to add
qsfp diag information support to ethtool, but that probably
got lost on the list, not sure.

Cheers,
Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ethtool: git tree not updated to v3.18
  2015-04-01 21:30 ethtool: git tree not updated to v3.18 Jesse Brandeburg
  2015-04-02  9:50 ` Daniel Borkmann
@ 2015-04-02 18:23 ` Ben Hutchings
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2015-04-02 18:23 UTC (permalink / raw)
  To: Jesse Brandeburg; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Wed, 2015-04-01 at 14:30 -0700, Jesse Brandeburg wrote:
> Hi Ben, 
> 
> When trying to check a bug just now I noticed that the master
> branch of
> git://git.kernel.org/pub/scm/network/ethtool/ethtool
> 
> still points to the v3.16 tag.
> 
> But kernel.org shows version 3.18 released.  I did some quick
> investigation and it looks like the v3.18 tag points to a dangling
> commit that is not on a branch.
> 
> $ git log --graph --oneline v3.18 |head -n5
> * ba9a11a Release version 3.18.
> * 1e8811a Fix build with musl by using more common typedefs
> * 99bc878 bug fix: SFP Tx BIAS uses memory wrong offset
> * 4614098 Release version 3.16.
> * 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing
> 
> $ git log --graph --oneline origin/master |head -n5
> * 4614098 Release version 3.16.
> * 14ef76c test-cmdline: Disable test cases for --rxfh hash key parsing
> * 86c0326 ethtool: Support for configurable RSS hash key
> * e633626 ethtool-copy.h: sync with net
> * 05b8ad5 Release version 3.14.
> 
> Maybe you can merge the commits from your working branch back onto
> master and make another 3.18.1 tag or something.
> 
> I just did:
> git checkout master
> git merge v3.18
> 
> which worked okay, I think

Sorry about that, I pushed the tag but not the master branch when
releasing 3.18.  This should be fixed now.

There's a long weekend coming up, and I hope to get to the submitted
patches and make a 4.0 release then.

Ben.

-- 
Ben Hutchings
Lowery's Law:
             If it jams, force it. If it breaks, it needed replacing anyway.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-02 18:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-01 21:30 ethtool: git tree not updated to v3.18 Jesse Brandeburg
2015-04-02  9:50 ` Daniel Borkmann
2015-04-02 18:23 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).