From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chien.yen@oracle.com, rds-devel@oss.oracle.com,
agrover@redhat.com, clm@fb.com, zab@zabbo.net,
ajaykumar.hotchandani@oracle.com,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCHv2 3/6] rds: check for excessive looping in rds_send_xmit
Date: Thu, 02 Apr 2015 14:08:50 -0400 (EDT) [thread overview]
Message-ID: <20150402.140850.1775436517754499795.davem@davemloft.net> (raw)
In-Reply-To: <5f877b89716358c7a08272275979b5e039ca1c29.1427983908.git.sowmini.varadhan@oracle.com>
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 2 Apr 2015 10:19:37 -0400
> @@ -177,6 +178,18 @@ int rds_send_xmit(struct rds_connection *conn)
>
> rm = conn->c_xmit_rm;
>
> + if (!rm) {
> + same_rm = 0;
> + } else {
> + same_rm++;
> + if (same_rm >= 4096) {
> + printk_ratelimited(KERN_ERR "RDS: Stuck rm\n");
> + cond_resched();
> + ret = -EAGAIN;
> + break;
> + }
> + }
> +
I'm not accepting junk like this.
I want to know exactly how this situation can occur, in detail, and
then and only then can we start to talk about more reasonable
solutions to this bug.
This looks like a minimal effort hack to make a hang go away, and
even more concerning is that a change like this is submitted with
a commit message that is essentially empty.
Sorry, this is not acceptable.
next prev parent reply other threads:[~2015-04-02 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:19 [PATCHv2 0/6] RDS: RDS core bug fixes Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 1/6] RDS: Re-add pf/sol access via sysctl Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 2/6] RDS: only use passive connections when addresses match Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 3/6] rds: check for excessive looping in rds_send_xmit Sowmini Varadhan
2015-04-02 18:08 ` David Miller [this message]
2015-04-02 14:19 ` [PATCHv2 4/6] RDS: make sure not to loop forever inside rds_send_xmit Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 5/6] RDS: rds_send_xmit is called under a spinlock, lets not do a cond_resched() Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 6/6] RDS: don't trust the LL_SEND_FULL bit Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402.140850.1775436517754499795.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agrover@redhat.com \
--cc=ajaykumar.hotchandani@oracle.com \
--cc=chien.yen@oracle.com \
--cc=clm@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sowmini.varadhan@oracle.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).